From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.a.kubacki@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Fri, 13 Sep 2019 14:49:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 14:49:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="337026122" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga004.jf.intel.com with ESMTP; 13 Sep 2019 14:49:03 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Sep 2019 14:49:03 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX112.amr.corp.intel.com ([169.254.3.89]) with mapi id 14.03.0439.000; Fri, 13 Sep 2019 14:49:03 -0700 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Wei, David Y" CC: "Wu, Hao A" , "Gao, Liming" , "Sinha, Ankit" , "Agyeman, Prince" , "Desimone, Nathaniel L" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Change to gEfiSmmSmramMemoryGuid to fix build error Thread-Topic: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Change to gEfiSmmSmramMemoryGuid to fix build error Thread-Index: AQHVaniN8CveCwQPEkeYclcg7TYU/qcqJLNw Date: Fri, 13 Sep 2019 21:49:02 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588AC5F89@ORSMSX121.amr.corp.intel.com> References: <5162c16bb4b694a8243a02b7041e74a7def0ffd3.1568402462.git.david.y.wei@intel.com> In-Reply-To: <5162c16bb4b694a8243a02b7041e74a7def0ffd3.1568402462.git.david.y.wei@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjE0MzY1ZTItNDQyZi00ZDVhLTg0M2MtMDVlYTU0NGY5OGFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWTlZdE1Pek1oaHpjdzl5aXdYUVE3TFZLWFNoclhkcXVnTXg4YkFYZlljMEpKZkVGQTliQmV5RVBlZDNqbHBmVCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The code changes look good. * The subject should indicate [edk2-platforms] for changes in the edk2-pla= tforms repository. * PatchCheck.py has the following errors. Please help fix it. The commit message format is not valid: * First line of commit message (subject line) is too long. * Line 3 of commit message is too long. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-F= ormat The code passed all checks. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of David > Wei > Sent: Friday, September 13, 2019 2:17 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming ; > Sinha, Ankit ; Agyeman, Prince > ; Kubacki, Michael A > ; Desimone, Nathaniel L > ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Change to > gEfiSmmSmramMemoryGuid to fix build error >=20 > MinPlatform PKG now use gEfiSmmSmramMemoryGuid instead of > gEfiSmmPeiSmramMemoryReserveGuid to build memory HOB. > SimicsOpenBoardPkg need to update for it accordingly. >=20 > Cc: Hao Wu > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Agyeman Prince > Cc: Kubacki Michael A > Cc: Nate DeSimone > Cc: Michael D Kinney >=20 > Signed-off-by: David Wei > --- > Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c | 2 +- > Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > index 90e6d1d3cf..ee0eead5a8 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > @@ -449,7 +449,7 @@ QemuInitializeRam ( > SmramRanges =3D 1; >=20 > Hob.Raw =3D BuildGuidHob( > - &gEfiSmmPeiSmramMemoryReserveGuid, > + &gEfiSmmSmramMemoryGuid, > BufferSize > ); > ASSERT(Hob.Raw); > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > index ccc7037d75..e466d57e4e 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > @@ -39,7 +39,7 @@ >=20 > [Guids] > gEfiMemoryTypeInformationGuid > - gEfiSmmPeiSmramMemoryReserveGuid ## CONSUMES > + gEfiSmmSmramMemoryGuid ## CONSUMES >=20 > [LibraryClasses] > BaseLib > -- > 2.16.2.windows.1 >=20 >=20 >=20