From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Fri, 13 Sep 2019 14:54:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 14:54:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,501,1559545200"; d="scan'208";a="186571149" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga007.fm.intel.com with ESMTP; 13 Sep 2019 14:54:19 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Sep 2019 14:54:18 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX162.amr.corp.intel.com ([169.254.3.217]) with mapi id 14.03.0439.000; Fri, 13 Sep 2019 14:54:18 -0700 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Wei, David Y" CC: "Wu, Hao A" , "Gao, Liming" , "Sinha, Ankit" , "Agyeman, Prince" , "Desimone, Nathaniel L" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot priority by default Thread-Topic: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot priority by default Thread-Index: AQHValRogF30r1xwvEeU15UFJDRk/acqJnvQ Date: Fri, 13 Sep 2019 21:54:17 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588AC5FB5@ORSMSX121.amr.corp.intel.com> References: <075b6bb19fdbcdd6bb8415af088f6eff5e3e9c1d.1568393577.git.david.y.wei@intel.com> In-Reply-To: <075b6bb19fdbcdd6bb8415af088f6eff5e3e9c1d.1568393577.git.david.y.wei@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJkOGJhODktNTcyNi00ZmFkLWJkNDUtODA2Mjc3NGZhMmM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOWRUb2Y3V3FEVUhwb2cwVllLZEZ5dmwzb042Uk9nbmQzMnVtYVB6TWh1TFBuY1FPOFBpVFh1WmNua3RHXC93TEIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable * The subject should indicate [edk2-platforms] for changes in the edk2-plat= forms repository. * PatchCheck.py has the following errors. Please help fix it. The commit message format is not valid: * Line 3 of commit message is too long. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-F= ormat Code format is not valid: * EFI_D_INFO was used, but DEBUG_INFO is now recommended File: Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManager= Lib/BdsPlatform.c Line: DEBUG((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n")); > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of David > Wei > Sent: Friday, September 13, 2019 9:58 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming ; > Sinha, Ankit ; Agyeman, Prince > ; Kubacki, Michael A > ; Desimone, Nathaniel L > ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot > priority by default >=20 > When running networks of multiple machines, Simics assigns different dis= k > IDs to each disk created. > this change the boot priority and can't boot from SATA HDD directly. > Clear boot priority in NVRAM can fix this issue. >=20 > Cc: Hao Wu > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Agyeman Prince > Cc: Kubacki Michael A > Cc: Nate DeSimone > Cc: Michael D Kinney >=20 > Signed-off-by: David Wei > --- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 14 +++++++= ++++- > -- > 1 file changed, 11 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd > sPlatform.c > index 953a4a6c15..926ed94ca1 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/B > +++ dsPlatform.c > @@ -338,10 +338,18 @@ PlatformBootManagerBeforeConsole ( > VOID > ) > { > -// EFI_HANDLE Handle; > -// EFI_STATUS Status; > + EFI_BOOT_MANAGER_LOAD_OPTION *NvBootOptions; > + UINTN NvBootOptionCount; > + UINTN Index; > + EFI_STATUS Status; > + > + DEBUG((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n")); > + > + NvBootOptions =3D EfiBootManagerGetLoadOptions(&NvBootOptionCount, > + LoadOptionTypeBoot); for (Index =3D 0; Index < NvBootOptionCount; > Index++) { > + Status =3D > + > EfiBootManagerDeleteLoadOptionVariable(NvBootOptions[Index].OptionNu > mb > + er, LoadOptionTypeBoot); } >=20 > - DEBUG ((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n")); > InstallDevicePathCallback (); >=20 > VisitAllInstancesOfProtocol (&gEfiPciRootBridgeIoProtocolGuid, > -- > 2.16.2.windows.1 >=20 >=20 >=20