From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.82]) by mx.groups.io with SMTP id smtpd.web08.3068.1643028132020559953 for ; Mon, 24 Jan 2022 04:42:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=d268Z4Pp; spf=pass (domain: arm.com, ip: 40.107.2.82, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZ5h9ObYjeQTtRKkzUnS4li/GT8SqFT2p8QKLl0y1UQ=; b=d268Z4PpMb9YXuuqxcgNK467eyz87ISIWIaLkWsA+1pJCwVwLhZutkX1N1C0RiZTIxDfTUv3p3ZG+9bAr/zCd0A3+ipBH3R6cm8O1HEHAJNTwZMRGE1ESLLJRtOHYXzFGRZLrKjSWaGVGF0/eAnVLSFbRDYQZmhWIgfBS4jKFjc= Received: from DU2P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::14) by AM6PR08MB3207.eurprd08.prod.outlook.com (2603:10a6:209:42::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Mon, 24 Jan 2022 12:42:07 +0000 Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::cf) by DU2P251CA0004.outlook.office365.com (2603:10a6:10:230::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.17 via Frontend Transport; Mon, 24 Jan 2022 12:42:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7 via Frontend Transport; Mon, 24 Jan 2022 12:42:07 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Mon, 24 Jan 2022 12:42:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 00ffbda7cc147a0d X-CR-MTA-TID: 64aa7808 Received: from 1c28e163102b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 875C3A55-81CF-4C2F-8806-8B0EB0B2F7DC.1; Mon, 24 Jan 2022 12:42:01 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1c28e163102b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 Jan 2022 12:42:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CfeSBKrCMi0BXdgAeb/z9rWAGsUrNProKqOw85rCDvkSKwuSBT83tKviY8Sg5OUGu1zV+G8EGoiIf+LtfPZ69Q5GIjdFb1OcNoJWfm2M36KAFrkh79JTgtb5c6sjiSEr7faIxg4a2RiH/LAwkPM/a4FJs7jMfQscWcsNkdOK6lCOcu1R/rqMPaeJQnQDPPThebqsglHFSF1/AuyRGMf+AeYemJPyY6bTHY807jnxAehx3dd7cTJOA244PZ7pMhZtInfXxwTUmpIXgt8baVN/ksVCaWi2eNsABxqSYVwgeC1EyDaECbRPPBy3FWibVO7gmzZWvy7Giulxlh0aysBT3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZ5h9ObYjeQTtRKkzUnS4li/GT8SqFT2p8QKLl0y1UQ=; b=NXEZR6A+EzfsktWCNxHeYsMwzJ+zUiwi+GW7vypFAPtksIf0WTYzRHsoLLBuf5vKuJi6ctroucVaaeg9TD8UcyGauUW1TLCEvtqOcn29nzYOCTWpvgACIp7UDiobgfrMM90HBYz1PLRUZdq4v695My7o3yWPnNcgoVLCqdJyIzYpa3Fu9w6uvkUuNq+KVHCgWkcjbotDNjseSocsnwtnk8D2TRu39BsOullo6QE4pZTt9k/OCzA48GsoYz9uIflERZMQ5JQJWCrFHmX4N4GI59nPo8wzkXzJNcdmq5J8nMxQOawXA+SvwruyO5k7IwvJnNLw99OWYoPcqZYoWr5FCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZ5h9ObYjeQTtRKkzUnS4li/GT8SqFT2p8QKLl0y1UQ=; b=d268Z4PpMb9YXuuqxcgNK467eyz87ISIWIaLkWsA+1pJCwVwLhZutkX1N1C0RiZTIxDfTUv3p3ZG+9bAr/zCd0A3+ipBH3R6cm8O1HEHAJNTwZMRGE1ESLLJRtOHYXzFGRZLrKjSWaGVGF0/eAnVLSFbRDYQZmhWIgfBS4jKFjc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3991.eurprd08.prod.outlook.com (2603:10a6:20b:a8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Mon, 24 Jan 2022 12:41:59 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%8]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 12:41:59 +0000 Subject: Re: [PATCH v6 0/4] Enable CCIX port as PCIe root host on N1SDP To: Khasim Syed Mohammed , devel@edk2.groups.io Cc: nd@arm.com, pierre.gondois@arm.com References: <20220122152615.17366-1-khasim.mohammed@arm.com> From: "Sami Mujawar" Message-ID: <49ade9c4-44ca-ae57-003c-6c756cafd1f8@arm.com> Date: Mon, 24 Jan 2022 12:42:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20220122152615.17366-1-khasim.mohammed@arm.com> X-ClientProxiedBy: LO2P265CA0245.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 88af2ace-8f60-43d3-71eb-08d9df36eea6 X-MS-TrafficTypeDiagnostic: AM6PR08MB3991:EE_|DB5EUR03FT046:EE_|AM6PR08MB3207:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iGPNkRsq7atJCPS2mNN1TkRLiiulaR7GkuMmdiHNx0Qg1vMDjkcFBVD2ftCuwwHuL4vLP68UvPnQTprnhMMLEcxOiZTHocxR/fzPXxqe/M0gYZBcxIKpsaybWLEhNY++GFn7BiQSoQDt1QUfUI0tfs2CHmDjsKzUoaR2IXTHp0n0hjNSt/XYWK1EKoqCz310VV+rPYu5rUN/bqAU7xa8ML6ZJ3d2H2xmqdK9lOr5QYmfUltH4CdUFUzyIMfDPawQOM7EhaBr6YlTlbsknR3HJhYg5rmQ64YJ8BOnOb9aaNsmjdj3gZE9oEurb6HKXJVmbjArSLqFHBjgPac9s1p7/4ey6R+bra7/Wge8peEnK4DO6HldaCIxcxRWZnqwUNy9uj5KnrrlIUpVcYS8qFovaiDxgj5PBHN1B8vzsQlDNSkoDFntRxiF0Tz24nQvoMx9kq8rxTEy8vaadLvXT/Tmu3K7tjiPFoWACaOE3BglwWHo2NHbx4BOZX6b12+ifJh9JKXZTeQGyGQ3+11YuXOEy2IrOLK52kVdxncqjWJ6Xox8bi9mAou3K1folKyHi/p2NwNkEZM52vxW/LW6N1mR+pe/JrNMr5eLCqI+zQ+gJCXgAwvJsl3qgG0iPq1Tm9VZK7WZksSZxjLy7W83ATlDptC0SOb8C7U1TEANxdruDa2oo6wXfZ2irbIVSWGcpiXj7jXPuqfUmLnNQA/Uf4aKftv10PidhA18qnnmt11x9sVwFB/eSov+J8UCDOFtuksXQDwCp2WyG9SK+dEWugWDeY79eW4xhKcFCFeLDqYdngqI8JlE8VGEEjmJUqD4aGw8IPcRAFby5wnJJoAJ+/jSSYjWWTqCV/Qs3vzJx++spdk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(53546011)(86362001)(66556008)(6486002)(66476007)(52116002)(316002)(5660300002)(38100700002)(66946007)(508600001)(8676002)(31696002)(6506007)(8936002)(2906002)(966005)(36756003)(44832011)(19627235002)(6512007)(6666004)(26005)(38350700002)(2616005)(4326008)(31686004)(186003)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3991 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7493fc1e-d161-4c66-c805-08d9df36e997 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H3OkpkEOqWdAhYCI0c4vC5b7BCAowJZKqaF5E0BKacefvrO0i5hL3xraAGSkg2jhPZSlPZazqY1OiaSqfhZEpqKjyR4dEIfWcwqNuM+PQoCF50wQmFBejpgTr48UcjwYkknLNSc29nFy2hdkiWq5Ayk78NJP4vNoAYfaX2OKw78L+Z0TFT4NBjPnVeCzmuTLUWa7b+X4ABvEoZJSw+mA6owIubP4lQa29Xb/ZUyDP4PGg3SsD+aEPog52G5XIdrsEr3rhlnIhHgKtBBwoPyzYS5G5D67JXUCXS37kEOiBmdrpM3W3V1jcq1toGbkP7C68Fvm3yoMDX66itVNDQcymAckqFAtqgqQm26G7Nko3lAtno7FV+7rl59onTPfMJgwUR4fnelHh/JKcbXIFrcZWuOGUVF2PRqeQjJzTxaO3zTS5Wx3l1odRzCUFtZoZ/w/CCkPdU0yQk52Syswl/3VLbPS8yiNndSsU330UIa1q7xU2jB2+UOofVxpkSx/gsFSUAuvdsq5urScpfiwc36jOR8WlfomDhsD/LTdHhVeeN5aY3AWwTv4A/wMWxae/d/Bsw/gle1/nw4KXetGc0mhU/XoMd5J2BgoTHxvo//xHrQdWeHXgzIWg98r+//0lOUy1ibCE2NyPcd66j+bKRSjgkiW8n2pXCFxEDRVrIfbKAug2ildrrvTYp/pvkGS4HAtBFVVFhck2/CwvlufEDZv9CxOYjfUw8eB634/bDsFkz7ym1Txr1zXINoJUh5jSfEnuJSOox6phBA1MGn6eITQlYG7BfCUuGCsuPSw5Sh90Sv+nR6/cxu7gsOGED2ra/ANpH0DU76T24cgHXa86uziqO8WOIVgqrGqHhOu5l0PhIPqLL/+jilVp/P+mEUNZPxxitlT2iXkhZLEvzlW9WiO1A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(40470700004)(46966006)(2616005)(2906002)(36860700001)(6486002)(81166007)(6512007)(31696002)(336012)(82310400004)(70586007)(8676002)(8936002)(70206006)(26005)(186003)(47076005)(86362001)(6506007)(508600001)(316002)(83380400001)(4326008)(40460700003)(19627235002)(966005)(53546011)(356005)(36756003)(5660300002)(44832011)(6666004)(31686004)(32563001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 12:42:07.4674 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88af2ace-8f60-43d3-71eb-08d9df36eea6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3207 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Khasim, Thank you for the updated patch series. These changes look good to me. For this series, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/01/2022 03:26 PM, Khasim Syed Mohammed wrote: > The patch series removes PciExpressLib and enables CCIX port > as PCIe root on N1SDP. > > V6: > - Sort PCDs in alphabetical order > - Replace ASSERT calls with a if condition to capture the failure > > V5: > - Split the CCIX patch, separate PCD updates and CCIX root port enablement. > - Use GET_SEG_ macro for segment detection and update logic accordingly. > > V4: > - Remove PciExpressLib and use PciSegmentLib instead. More detailed explanation > is included in the patch. > > V3: > - The conditional logic in GetPciExpressAddress is made simple. > - Removed few more PCD entries that were unused. > - Removed hardcoded entries. > > V2: > - Removed few PCDs entries that were not used. > - Migrated to latest version edk2-platform and validated the patches. > > V1: > - The PciExpressLib is updated to validate the PCIe addresses > and introducing corresponding PCD entries. > - A custom PCI Segment library is adapted from SynQuacerPciSegmentLib > and ported for N1Sdp. > - The root complex node info in PciHostBridge library is updated to > include the CCIX port information. > > The changes can be seen at: > https://github.com/khasim/edk2-platforms-n1sdp/tree/n1sdp-ccix-root > > Khasim Syed Mohammed (4): > Silicon/ARM/NeoverseN1Soc: Port PCI Segment Library > Silicon/ARM/NeoverseN1Soc: Update PCDs to support multiple PCI root > ports > Silicon/ARM/NeoverseN1Soc: Add CCIX root complex support > Silicon/ARM/NeoverseN1Soc: Remove PciExpressLib use PciSegmentLib > instead > > .../AslTables/SsdtPci.asl | 8 +- > .../AslTables/SsdtRemotePci.asl | 4 +- > .../ConfigurationManager.c | 24 +- > .../ConfigurationManagerDxe.inf | 18 +- > Platform/ARM/N1Sdp/N1SdpPlatform.dec | 8 - > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +- > .../PciExpressLib.c | 1589 ---------------- > .../PciExpressLib.inf | 56 - > .../PciHostBridgeLib/PciHostBridgeLib.c | 71 +- > .../PciHostBridgeLib/PciHostBridgeLib.inf | 11 +- > .../Library/PciSegmentLib/PciSegmentLib.c | 1622 +++++++++++++++++ > .../Library/PciSegmentLib/PciSegmentLib.inf | 38 + > .../Library/PlatformLib/PlatformLib.inf | 1 + > .../Library/PlatformLib/PlatformLibMem.c | 4 +- > Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec | 64 +- > 15 files changed, 1808 insertions(+), 1715 deletions(-) > delete mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/PciExpressLib.c > delete mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/PciExpressLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciSegmentLib/PciSegmentLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciSegmentLib/PciSegmentLib.inf >