From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AB99F78003C for ; Thu, 25 Jan 2024 23:28:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pYd5vb0GGjRbJPL7fkgBDDQINyP0ursGmkDbOqsvT+A=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706225296; v=1; b=ADbyO1236u5lp8nLrg4vYT59yH2/0vi/WX9b3EGMYw9LWr09xo58E92wmqT1ZtFRrIscQsib Gn4RS5VLZ6QqMF6rDdxd4zCbIj3oitsqd1sIiH0cvLOMpeVhY7dwHO2dU9yGUmN14xDJ5fyxnfc HQYXzgdotG+bcoCCElqhTTdg= X-Received: by 127.0.0.2 with SMTP id U3IsYY7687511xSKCGDbP4ff; Thu, 25 Jan 2024 15:28:16 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.1582.1706225295647099310 for ; Thu, 25 Jan 2024 15:28:15 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-B1hz0hOfPiSx6shPR2j_UA-1; Thu, 25 Jan 2024 18:28:11 -0500 X-MC-Unique: B1hz0hOfPiSx6shPR2j_UA-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18119185A780; Thu, 25 Jan 2024 23:28:11 +0000 (UTC) X-Received: from [10.39.195.100] (unknown [10.39.195.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96CBC2026F95; Thu, 25 Jan 2024 23:28:09 +0000 (UTC) Message-ID: <49b6aff8-8c90-ee7f-d20f-e687fdcc2a4b@redhat.com> Date: Fri, 26 Jan 2024 00:28:08 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process. To: devel@edk2.groups.io, pedro.falcato@gmail.com, kraxel@redhat.com Cc: Ard Biesheuvel , Erdem Aktas , Michael Roth , Min Xu , Jiewen Yao , Tom Lendacky , Oliver Steffen References: <20240125082311.310203-1-kraxel@redhat.com> <20240125082311.310203-2-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lQE1CL6guu1fvxFNQeEjgvV0x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ADbyO123; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/25/24 11:52, Pedro Falcato wrote: > On Thu, Jan 25, 2024 at 8:23 AM Gerd Hoffmann wrote: >> >> Specifically before running lzma uncompress of the main firmware volume. >> This is needed to make sure caching is enabled, otherwise the uncompress >> can be extremely slow. >> >> Adapt the ASSERTs and MTRR setup in PlatformInitLib to the changes. >> >> Background: Depending on virtual machine configuration kvm may uses EPT >> memory types to apply guest MTRR settings. In case MTRRs are disabled >> kvm will use the uncachable memory type for all mappings. Here is the >> linux kernel function handling this: > > It might not be wise to blat out GPLv2 source code in a commit message > :) Not that it's a violation of the GPL (we're not linking against it, > neither can the patch be considered a derivative work), but it might > just be a little too grey-area for a !GPL project. > I think you are right. How incredibly annoying. Perhaps we should replace the vmx_get_mt_mask() quote with a link like... https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/x86/kvm/vmx/vmx.c?h=v6.7.1#n7580 This link (including a line number) is stable, because it references a tag. "all problems in computer science can be solved by another layer of indirection" https://en.wikipedia.org/wiki/David_Wheeler_(computer_scientist)#Quotes Funnily enough, Linus would yell at us for this; IIRC he strongly prefers embedding information over linking information, in commit messages. :/ Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114479): https://edk2.groups.io/g/devel/message/114479 Mute This Topic: https://groups.io/mt/103950478/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-