From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4F0D62117B54F for ; Tue, 6 Nov 2018 12:34:46 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id 74-v6so15025809wrb.13 for ; Tue, 06 Nov 2018 12:34:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xklOuUPcRPS4y4RRvVI6f21w26zCjVg48UG3Z9ECGl0=; b=GJO2m7tBCK9sca/5CSfmt6Ots5xf1VD21JJE3WMGPQUK0PMj/he91tppQHNEx6/YlY ZfQPJa1G+FOqaJU/4FO7n4ENR8gAV2T1OSJH1fasFW/rYcigtl/GDT40D9AL8jwQZiro Yebh7+FfDGp1DdsAPzxC3XSZKFj6WnTNlT4b2fZphYeVvFQP2mHXLUNc0gztTHPIsJGm Ge95l+G3RM8nlzzMTpvzkzXR+H1AEXqPdkp6i4//BcmdzHlHu8oZF+LXjF8l2WKhZIZG MLodxrvEl8YVfkOCMWmuyj5at/w6kqOkbSXk00+Fg3JZrUQvfsiowDvwA4is0gFfyNwc 4KBQ== X-Gm-Message-State: AGRZ1gLtmh2FwupDg2Y+ZfdN0ZDvPQsFetAMVj/6Xu59fNeZTDpCXkku 2OpweEVZs21gMq7iaT7ZV30ZwxO9jdM= X-Google-Smtp-Source: AJdET5c72pgQwtX7qHKO4pPoED92mmmjP7ttx9j6zVlQWhuIl6p1y8LdkMendFHsJTEmTNl+viPWpg== X-Received: by 2002:a5d:6405:: with SMTP id z5-v6mr473399wru.64.1541536484896; Tue, 06 Nov 2018 12:34:44 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id 137-v6sm4318137wmo.43.2018.11.06.12.34.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 12:34:44 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-11-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <49cb8a32-81cc-5056-35f5-70b54c4e60c2@redhat.com> Date: Tue, 6 Nov 2018 21:34:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-11-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 20:34:47 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > The Data4 member of the GUID/EFI_GUID struct type is an array of > UINT8, so literals require two sets of { } braces. Add them where > missing. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++-- > IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > index bd7d4defc9a3..72f6a95ccb6d 100644 > --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > @@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > #define E1000_HII_FORM_GUID \ > { \ > - 0x77f2ea2f, 0x4312, 0x4569, 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 \ > + 0x77f2ea2f, 0x4312, 0x4569, { 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 } \ > } > > #define E1000_HII_DATA_GUID \ > { \ > - 0xa31abb16, 0xc627, 0x475b, 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 \ > + 0xa31abb16, 0xc627, 0x475b, { 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 } \ > } > > > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h > index 255f17aabaa4..b29a5002bb8e 100644 > --- a/IntelUndiPkg/GigUndiDxe/StartStop.h > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h > @@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #include "e1000.h" > > #define EFI_DRIVER_STOP_PROTOCOL_GUID \ > -{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ > -0xb5, 0xfd, 0x7d, 0xc1 } > +{ 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \ > +0xb5, 0xfd, 0x7d, 0xc1 } } > > typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL; > >