From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::443; helo=mail-pf1-x443.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 466E7202E5324 for ; Tue, 12 Feb 2019 22:36:23 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id z15so713364pfa.2 for ; Tue, 12 Feb 2019 22:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mPA04CIjGGatkRRYAMvg0BwF3xKQ5QV8+B2JcPOYdfU=; b=NvvlJPbaY935oYXR/xIjtj26+XsZjRL/ujCQTx6AKY838yNscJy532Kt5/swQnG0Mc pFYiF1J3R/sIGfCr1bLcszCeiukLj6k7dABm7c9XePw4zSISvZTTJUBaE0+ZFqBWQxkw Tk88ULwmEToD7qTuVawCfGeHGcr59svY0HrqWRHtFt3Mm6zaKhbrPWnucfsLKVNRLvJq WNlpz7h3LDboNWVGiARyuWHhPowFB0BJ36PZ+zDpWE4EKpItCI3VM+GPxWlq8KCqy5Ui ernu8+8uf1wWSwTgXD0hABhZYzMxf8FAQJEaSGzx3lb5tkc/G4VieyUOWUl8r5cB4048 J9EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mPA04CIjGGatkRRYAMvg0BwF3xKQ5QV8+B2JcPOYdfU=; b=F1ojMTIb5y7a/Y+Q/4+y/HeFgFqrZvfoXiWjiImEKoVqu7VrkwIzR0O+rqUFsrZ68O EYEqnox7d+MndMi5deLO+3I+AmhlTLwEcM+Q5HUo2TlZWnD6x5VoCl2S27yD2bjNISxo ScPOEjHGDFb6YMRBQj9zIHpBn3ZVBOyhBo+5Y+DKWPTln1N9QQjkehL8jtORNoKlp3OF 5tt0p8cF8tobnIW8kwz8/XFGu7AaFa3pLZSihP9JZrG9EM/rZcJiGplN8AOShQaAseMF u/kn5RAbNOk9dcLIYEBfEcmfy2gF1MpkKInXYhWuIhXG+NYGX4aBj0DvmdfToX4B7smY RLjA== X-Gm-Message-State: AHQUAuZcfMJ5lfZUiSqNWhNOazLjviG+AgoZx3ar8owWUWSHYMW/YTMN Zsk7TPV3/NnWd/8axeumXlp45Q== X-Google-Smtp-Source: AHgI3IZhBzq7pBQdBkfCrtI6HhNUSD41dirXTN+RZMMDXArh9bnA5J9xhVhhND40nf3g7AZS8L7jwg== X-Received: by 2002:a63:c40a:: with SMTP id h10mr7533616pgd.131.1550039783591; Tue, 12 Feb 2019 22:36:23 -0800 (PST) Received: from [10.58.0.74] ([64.64.108.254]) by smtp.gmail.com with ESMTPSA id f62sm19404064pgc.67.2019.02.12.22.36.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 22:36:22 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-2-ming.huang@linaro.org> <20190211150505.h7itd4fqvrfazeqs@bivouac.eciton.net> From: Ming Huang Message-ID: <49ffdca4-332a-2678-145a-50fb2be4d000@linaro.org> Date: Wed, 13 Feb 2019 14:36:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190211150505.h7itd4fqvrfazeqs@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 06:36:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/11/2019 11:05 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:21PM +0800, Ming Huang wrote: >> SerdesLib is useless for SmbiosMiscDxe and D06, so remove it. > > Should it not then also delete #include from > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, > Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c > ? > > Meanwhile, > Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c > and > Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c > both include this header, but > Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf > and > Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.inf > do not declare the dependency. OemMiscLibD06.c can remove the SerdesLib.h. As using the definitions in SerdesLib.h, other .c files can not remove the header file. > > Can you investigate and submit an updated patch addressing all of the > unnecessary references? This may takes a lot of time, as Hi1620(D06) is our important project, maybe we should focus on D06. Thanks > > Best Regards, > > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/D06.dsc | 2 -- >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 - >> 2 files changed, 3 deletions(-) >> >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc >> index 396bd03c9d24..cbbd99e4a659 100644 >> --- a/Platform/Hisilicon/D06/D06.dsc >> +++ b/Platform/Hisilicon/D06/D06.dsc >> @@ -64,8 +64,6 @@ [LibraryClasses.common] >> >> CpldIoLib|Silicon/Hisilicon/Library/CpldIoLib/CpldIoLib.inf >> >> - SerdesLib|Silicon/Hisilicon/Hi1620/Library/Hi1620Serdes/Hi1620SerdesLib.inf >> - >> TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf >> RealTimeClockLib|Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf >> OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf >> diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >> index 61cead7779b9..8e5c56fa41fd 100644 >> --- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >> +++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >> @@ -77,7 +77,6 @@ [LibraryClasses] >> >> IpmiCmdLib >> >> - SerdesLib >> >> [Protocols] >> gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED >> -- >> 2.9.5 >>