From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"sigmaepsilon92@gmail.com" <sigmaepsilon92@gmail.com>
Subject: Re: [PATCH 0/3] BaseTools GCC: pass CC flags to linker
Date: Wed, 3 Aug 2016 08:58:11 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155E4C14@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu9yMRnCZND6JAkrKCsbVz90zKc51130Stx6=1-5T3BE=A@mail.gmail.com>
Ard:
I see Steven says it doesn't work, yet. So, I am curious what real issue is resolved by this patch?
Thanks
Liming
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, August 03, 2016 4:23 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; edk2-devel@lists.01.org;
> leif.lindholm@linaro.org; sigmaepsilon92@gmail.com
> Subject: Re: [PATCH 0/3] BaseTools GCC: pass CC flags to linker
>
> On 2 August 2016 at 16:51, Ard Biesheuvel <ard.biesheuvel@linaro.org>
> wrote:
> > On 2 August 2016 at 16:50, Gao, Liming <liming.gao@intel.com> wrote:
> >> Ard:
> >> Without this change, GCC5 LTO can pass build. With it, what difference
> will be in the generated image? Original way may generate the wrong image,
> or new way will generate the smaller image?
> >>
> >
> > This is not about code size but about correctness. Compiler switches
> > for code model or alignment etc may affect the way code is generated
> > at link time by the LTO routines.
>
> Note that Steven mentions a similar problem in his CLANG38 series: he
> needs to pass -pie to the linker (or -fpie would be sufficient, I
> suspect) to prevent the linker from using the wrong code model when
> generating code from the LTO bytecode.
>
> Thanks,
> Ard.
next prev parent reply other threads:[~2016-08-03 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 14:39 [PATCH 0/3] BaseTools GCC: pass CC flags to linker Ard Biesheuvel
2016-08-02 14:39 ` [PATCH 1/3] BaseTools GCC: move -c compiler flag to build rules Ard Biesheuvel
2016-08-02 15:01 ` Leif Lindholm
2016-08-02 15:02 ` Ard Biesheuvel
2016-08-02 15:09 ` Ard Biesheuvel
2016-08-02 14:39 ` [PATCH 2/3] BaseTools GCC5: disable warnings-as-errors for now Ard Biesheuvel
2016-08-02 14:39 ` [PATCH 3/3] BaseTools GCC: add the compiler flags to the linker command line Ard Biesheuvel
2016-08-17 11:38 ` Shi, Steven
2016-08-17 11:42 ` Ard Biesheuvel
2016-08-17 12:24 ` Shi, Steven
2016-08-17 13:06 ` Ard Biesheuvel
2016-08-02 14:50 ` [PATCH 0/3] BaseTools GCC: pass CC flags to linker Gao, Liming
2016-08-02 14:51 ` Ard Biesheuvel
2016-08-03 8:22 ` Ard Biesheuvel
2016-08-03 8:58 ` Gao, Liming [this message]
2016-08-03 9:23 ` Ard Biesheuvel
2016-08-03 13:20 ` Gao, Liming
2016-08-03 15:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A1155E4C14@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox