public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"eugene@hp.com" <eugene@hp.com>
Subject: Re: [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics
Date: Fri, 12 Aug 2016 03:04:38 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EA81B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1470939632-32198-2-git-send-email-ard.biesheuvel@linaro.org>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Friday, August 12, 2016 2:21 AM
> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; eugene@hp.com; Gao,
> Liming <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics
> 
> This updates the RVCT CC flags so various diagnostics that trigger
> warnings-as-errors are silenced. In particular, RVCT complains about
> missing newlines at the end of source files, mixing of enums and int
> values and return statements followed by a break, all of which occur
> in the Tianocore codebase, but none of which are actual errors in the
> code. So just silence them.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 2002c4c0598b..e3d70133caaa 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -7449,7 +7449,7 @@ RELEASE_XCODE5_X64_CC_FLAGS   = -target
> x86_64-pc-win32-macho -c    -Os       -W
> 
> ##########################################################
> ##########################
> 
>  DEFINE RVCT_ALL_ASM_FLAGS   = --diag_suppress=1786 --
> diag_error=warning --apcs /interwork
> -DEFINE RVCT_ALL_CC_FLAGS    = --c90 --no_autoinline --asm --gnu --apcs
> /interwork --signed_chars --no_unaligned_access --split_sections --
> enum_is_int --preinclude AutoGen.h --diag_suppress=186 --diag_warning
> 167 --diag_error=warning --diag_style=ide --protect_stack
> +DEFINE RVCT_ALL_CC_FLAGS    = --c90 --no_autoinline --asm --gnu --apcs
> /interwork --signed_chars --no_unaligned_access --split_sections --
> enum_is_int --preinclude AutoGen.h --diag_suppress=186,188,1,111,68 --
> diag_warning 167 --diag_error=warning --diag_style=ide --protect_stack
>  DEFINE RVCT_ALL_DLINK_FLAGS = --no_scanlib --no_exceptions --
> datacompressor off --strict --symbols --diag_style=ide --no_legacyalign --
> scatter $(EDK_TOOLS_PATH)/Scripts/Rvct-Align32.sct
> 
> 
> ##########################################################
> ##########################
> --
> 2.7.4



  reply	other threads:[~2016-08-12  3:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 18:20 [PATCH 1/3] ArmPkg/CompilerIntrinsicsLib: replace memcpy and memset with C code Ard Biesheuvel
2016-08-11 18:20 ` [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics Ard Biesheuvel
2016-08-12  3:04   ` Gao, Liming [this message]
2016-08-11 18:20 ` [PATCH 3/3] MdePkg RVCT: add definition of UNREACHABLE Ard Biesheuvel
2016-08-12  3:04   ` Gao, Liming
2016-08-11 21:34 ` [PATCH 1/3] ArmPkg/CompilerIntrinsicsLib: replace memcpy and memset with C code Cohen, Eugene
2016-08-11 21:45   ` Ard Biesheuvel
2016-08-11 21:50     ` Cohen, Eugene
2016-08-11 21:53       ` Ard Biesheuvel
2016-08-11 23:04       ` Andrew Fish
2016-08-12  8:09         ` Ard Biesheuvel
2016-09-01 13:11 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A1155EA81B@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox