From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ml01.01.org (Postfix) with ESMTP id 1C4491A1DEC for ; Thu, 11 Aug 2016 20:04:54 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 11 Aug 2016 20:04:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,508,1464678000"; d="scan'208";a="1024102938" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 11 Aug 2016 20:04:42 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Aug 2016 20:04:41 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Aug 2016 20:04:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Fri, 12 Aug 2016 11:04:39 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "eugene@hp.com" Thread-Topic: [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics Thread-Index: AQHR8/0032K4xIKhV0OeqmE7exJmm6BEpH9A Date: Fri, 12 Aug 2016 03:04:38 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EA81B@shsmsx102.ccr.corp.intel.com> References: <1470939632-32198-1-git-send-email-ard.biesheuvel@linaro.org> <1470939632-32198-2-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1470939632-32198-2-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 03:04:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Friday, August 12, 2016 2:21 AM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; eugene@hp.com; Gao= , > Liming > Cc: Ard Biesheuvel > Subject: [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics >=20 > This updates the RVCT CC flags so various diagnostics that trigger > warnings-as-errors are silenced. In particular, RVCT complains about > missing newlines at the end of source files, mixing of enums and int > values and return statements followed by a break, all of which occur > in the Tianocore codebase, but none of which are actual errors in the > code. So just silence them. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 2002c4c0598b..e3d70133caaa 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -7449,7 +7449,7 @@ RELEASE_XCODE5_X64_CC_FLAGS =3D -target > x86_64-pc-win32-macho -c -Os -W >=20 > ########################################################## > ########################## >=20 > DEFINE RVCT_ALL_ASM_FLAGS =3D --diag_suppress=3D1786 -- > diag_error=3Dwarning --apcs /interwork > -DEFINE RVCT_ALL_CC_FLAGS =3D --c90 --no_autoinline --asm --gnu --apcs > /interwork --signed_chars --no_unaligned_access --split_sections -- > enum_is_int --preinclude AutoGen.h --diag_suppress=3D186 --diag_warning > 167 --diag_error=3Dwarning --diag_style=3Dide --protect_stack > +DEFINE RVCT_ALL_CC_FLAGS =3D --c90 --no_autoinline --asm --gnu --apcs > /interwork --signed_chars --no_unaligned_access --split_sections -- > enum_is_int --preinclude AutoGen.h --diag_suppress=3D186,188,1,111,68 -- > diag_warning 167 --diag_error=3Dwarning --diag_style=3Dide --protect_stac= k > DEFINE RVCT_ALL_DLINK_FLAGS =3D --no_scanlib --no_exceptions -- > datacompressor off --strict --symbols --diag_style=3Dide --no_legacyalign= -- > scatter $(EDK_TOOLS_PATH)/Scripts/Rvct-Align32.sct >=20 >=20 > ########################################################## > ########################## > -- > 2.7.4