From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ml01.01.org (Postfix) with ESMTP id 8014A1A1DEC for ; Thu, 11 Aug 2016 20:04:53 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 11 Aug 2016 20:04:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,508,1464678000"; d="scan'208";a="1012996815" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 11 Aug 2016 20:04:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Aug 2016 20:04:46 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Fri, 12 Aug 2016 11:04:44 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "eugene@hp.com" Thread-Topic: [edk2] [PATCH 3/3] MdePkg RVCT: add definition of UNREACHABLE Thread-Index: AQHR8/09+SwqNJkH406UxMnqXwmv86BEpI0A Date: Fri, 12 Aug 2016 03:04:44 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EA826@shsmsx102.ccr.corp.intel.com> References: <1470939632-32198-1-git-send-email-ard.biesheuvel@linaro.org> <1470939632-32198-3-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1470939632-32198-3-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/3] MdePkg RVCT: add definition of UNREACHABLE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 03:04:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Friday, August 12, 2016 2:21 AM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; eugene@hp.com; Gao= , > Liming > Cc: Ard Biesheuvel > Subject: [edk2] [PATCH 3/3] MdePkg RVCT: add definition of UNREACHABLE >=20 > The RVCT compiler in --gnu mode appears to simply strip of the __builtin > prefix when it encounters calls to __builtin_xxx() functions, and so > the __builtin_unreachable() we emit for GCC results in linker errors > regarding undefined references against 'unreachable()'. >=20 > So define UNREACHABLE() to a NOP instead. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > MdePkg/Include/Arm/ProcessorBind.h | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/MdePkg/Include/Arm/ProcessorBind.h > b/MdePkg/Include/Arm/ProcessorBind.h > index c2482c2f50f0..5ee7465c05a3 100644 > --- a/MdePkg/Include/Arm/ProcessorBind.h > +++ b/MdePkg/Include/Arm/ProcessorBind.h > @@ -28,6 +28,13 @@ > #pragma pack() > #endif >=20 > +// > +// RVCT does not support the __builtin_unreachable() macro > +// > +#ifdef __ARMCC_VERSION > +#define UNREACHABLE() > +#endif > + > #if _MSC_EXTENSIONS > // > // use Microsoft* C complier dependent integer width types > -- > 2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel