From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ml01.01.org (Postfix) with ESMTP id A8E1D1A1DFE for ; Thu, 11 Aug 2016 20:27:22 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 11 Aug 2016 20:27:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,508,1464678000"; d="scan'208";a="747641070" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 11 Aug 2016 20:27:22 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Aug 2016 20:27:22 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Aug 2016 20:27:22 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Fri, 12 Aug 2016 11:27:21 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Zhu, Yonghong" Thread-Topic: [edk2] [PATCH 2/2] BaseTools ARM AARCH64: drop redundant compiler arguments Thread-Index: AQHR88GXVVjt/14DfkOn+/ZhBj/8caBEq1aQ Date: Fri, 12 Aug 2016 03:27:20 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EA89B@shsmsx102.ccr.corp.intel.com> References: <1470914055-28034-1-git-send-email-ard.biesheuvel@linaro.org> <1470914055-28034-2-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1470914055-28034-2-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] BaseTools ARM AARCH64: drop redundant compiler arguments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 03:27:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Thursday, August 11, 2016 7:14 PM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming > ; Zhu, Yonghong > Cc: Ard Biesheuvel > Subject: [edk2] [PATCH 2/2] BaseTools ARM AARCH64: drop redundant > compiler arguments >=20 > The ARM and AARCH64 CC_FLAGS definitions include both > GCC_ALL_CC_FLAGS > and GCC44_ALL_CC_FLAGS, resulting in many of the compiler arguments > being passed twice. Since the CLANG35 definitions do not refer to > GCC44_ALL_CC_FLAGS, drop the reference for GCCx as well. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 2002c4c0598b..d6d3ed380668 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4400,7 +4400,7 @@ DEFINE GCC46_X64_DLINK_FLAGS =3D > DEF(GCC45_X64_DLINK_FLAGS) > DEFINE GCC46_X64_DLINK2_FLAGS =3D DEF(GCC45_X64_DLINK2_FLAGS) > DEFINE GCC46_ASM_FLAGS =3D DEF(GCC45_ASM_FLAGS) > DEFINE GCC46_ARM_ASM_FLAGS =3D $(ARCHASM_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > -DEFINE GCC46_ARM_CC_FLAGS =3D $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) > DEF(GCC_ARM_CC_FLAGS) -fstack-protector -mword-relocations -save- > temps > +DEFINE GCC46_ARM_CC_FLAGS =3D $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ARM_CC_FLAGS) -fstack-protector -mword- > relocations -save-temps > DEFINE GCC46_ARM_CC_XIPFLAGS =3D - > D__ARM_FEATURE_UNALIGNED=3D0 > DEFINE GCC46_ARM_DLINK_FLAGS =3D DEF(GCC_ARM_DLINK_FLAGS) - > Wl,--oformat=3Delf32-littlearm > DEFINE GCC46_ARM_DLINK2_FLAGS =3D > DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,-- > defsym=3DPECOFF_HEADER_SIZE=3D0x220 > @@ -4419,7 +4419,7 @@ DEFINE GCC47_ARM_ASM_FLAGS =3D > DEF(GCC46_ARM_ASM_FLAGS) > DEFINE GCC47_AARCH64_ASM_FLAGS =3D $(ARCHASM_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > DEFINE GCC47_ARM_CC_FLAGS =3D DEF(GCC46_ARM_CC_FLAGS) > DEFINE GCC47_ARM_CC_XIPFLAGS =3D DEF(GCC_ARM_CC_XIPFLAGS) > -DEFINE GCC47_AARCH64_CC_FLAGS =3D $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) -mcmodel=3Dlarge > DEF(GCC_AARCH64_CC_FLAGS) -save-temps > +DEFINE GCC47_AARCH64_CC_FLAGS =3D $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) -mcmodel=3Dlarge DEF(GCC_AARCH64_CC_FLAGS) - > save-temps > DEFINE GCC47_AARCH64_CC_XIPFLAGS =3D > DEF(GCC_AARCH64_CC_XIPFLAGS) > DEFINE GCC47_ARM_DLINK_FLAGS =3D DEF(GCC46_ARM_DLINK_FLAGS) > DEFINE GCC47_ARM_DLINK2_FLAGS =3D DEF(GCC46_ARM_DLINK2_FLAGS) > -- > 2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel