From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ml01.01.org (Postfix) with ESMTP id 52C781A1E0F for ; Mon, 15 Aug 2016 19:17:07 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 15 Aug 2016 19:17:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,528,1464678000"; d="scan'208,217";a="156278207" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 15 Aug 2016 19:17:07 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 15 Aug 2016 19:17:06 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Tue, 16 Aug 2016 10:16:48 +0800 From: "Gao, Liming" To: Kurt Kennett , "afish@apple.com" CC: edk2-devel Thread-Topic: [edk2] Setting BuildOptions by module type does not seem to work Thread-Index: AdH3DXjXZzkLe6CzToa1ZeYDl2WXa///gSCAgAADiQCAAA91gIAAB1gA//7uKSA= Date: Tue, 16 Aug 2016 02:16:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EB6CE@shsmsx102.ccr.corp.intel.com> References: <56352D44-41C4-49D8-8BFA-C92B84CC0CDC@apple.com> <4FA3496D-C050-40FA-8CB1-E3603E431E79@apple.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: Setting BuildOptions by module type does not seem to work X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 02:17:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, This style has been defined in DSC spec 1.26. It can be downloaded from h= ttps://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20Specificati= ons Thanks Liming From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Kurt= Kennett Sent: Tuesday, August 16, 2016 1:56 AM To: afish@apple.com Cc: edk2-devel Subject: Re: [edk2] Setting BuildOptions by module type does not seem to wo= rk Okay this seems to work: [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] Thanks Andrew. (doesn't match the spec though :) ) K2 -----Original Message----- From: afish@apple.com [mailto:afish@apple.com] Sent: Monday, August 15, 2016 10:30 AM To: Kurt Kennett Cc: edk2-devel Subject: Re: [edk2] Setting BuildOptions by module type does not seem to wo= rk > On Aug 15, 2016, at 9:34 AM, Kurt Kennett wrote: > > No, I had not tried that. I tried it now and it does not seem to work. > > I have: > > [BuildOptions.AARCH64.common] > *_VS2015x86_AARCH64_DLINK_FLAGS =3D /BORK > > [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] > *_VS2015x86_AARCH64_DLINK_FLAGS =3D /PLOR > > [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER] > *_VS2015x86_AARCH64_DLINK_FLAGS =3D /BONK > > And the only one that makes it to the command line is the /BORK one. > > (The tools do not complain about the specification of options as above). > I'm guessing the syntax checking is not very good? [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER] I see the [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] form used in other= places, but you have an extra .common? Thanks, Andrew Fish > K2 > > -----Original Message----- > From: afish@apple.com [mailto:afish@apple.com] > Sent: Monday, August 15, 2016 9:22 AM > To: Kurt Kennett > Cc: edk2-devel > Subject: Re: [edk2] Setting BuildOptions by module type does not seem > to work > > >> On Aug 15, 2016, at 9:10 AM, Kurt Kennett wrote: >> >> DSC spec (January 2016 1.26) says I can do this: >> >> (Section 3.6 pp 76) >> >> ... >> * [BuildOptions.$(arch).CodeBase.Edk2ModuleType] >> ... >> >> And this works fine: >> >> [BuildOptions.AARCH64.common] >> *_VS2015x86_*_DLINK_FLAGS =3D /BORK >> >> But when I also do: >> >> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] >> *_VS2015x86_*_DLINK_FLAGS =3D /PLOR >> >> The link flags are not affected on the command line - they get the /BORK= for all module types, but not the /PLOR for DXE_RUNTIME_DRIVERs. >> > > Kurt, > > Have you tried [BuildOptions.AARCH64.EDKII.DXE_RUNTIME_DRIVER]? Do you ne= ed EDK compatibility? > > I'm guessing that works given: > ~/work/src/edk2(master)>git grep "BuildOptions." -- *.dsc | grep > DXE_RUNTIME_DRIVER > OvmfPkg/OvmfPkgIa32.dsc:49:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIV > ER] > OvmfPkg/OvmfPkgIa32X64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_D > RIVER] > OvmfPkg/OvmfPkgX64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVE > R] > QuarkPlatformPkg/Quark.dsc:885:[BuildOptions.common.EDKII.DXE_RUNTIME_ > DRIVER] > > >> I'm not familiar with the DSC processing tools source. Anybody know wher= e to look to see why not? >> > > It starts here: > https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/ > build/build.py and uses some code from: > https://github.com/tianocore/edk2/tree/master/BaseTools/Source/Python/ > Common > > Thanks, > > Andrew Fish > >> K2 >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel