public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of ResetSystem to UEFI Spec
Date: Tue, 16 Aug 2016 04:49:14 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EB7E4@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20160810055611.266232-2-ruiyu.ni@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, August 10, 2016 1:56 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of
> ResetSystem to UEFI Spec
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Uefi/UefiSpec.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> b/MdePkg/Include/Uefi/UefiSpec.h
> index e8feed1..57cb4e8 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -1004,11 +1004,15 @@ EFI_STATUS
> 
>    @param[in]  ResetType         The type of reset to perform.
>    @param[in]  ResetStatus       The status code for the reset.
> -  @param[in]  DataSize          The size, in bytes, of WatchdogData.
> +  @param[in]  DataSize          The size, in bytes, of ResetData.
>    @param[in]  ResetData         For a ResetType of EfiResetCold, EfiResetWarm,
> or
>                                  EfiResetShutdown the data buffer starts with a Null-
> terminated
>                                  string, optionally followed by additional binary data.
> -
> +                                The string is a description that the caller may use to further
> +                                indicate the reason for the system reset. ResetData is only
> +                                valid if ResetStatus is something other than EFI_SUCCESS
> +                                unless the ResetType is EfiResetPlatformSpecific
> +                                where a minimum amount of ResetData is always required.
>  **/
>  typedef
>  VOID
> --
> 2.9.0.windows.1



  reply	other threads:[~2016-08-16  4:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  5:56 [PATCH 00/11] Add ResetPlatformSpecific() to ResetSystemLib Ruiyu Ni
2016-08-10  5:56 ` [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of ResetSystem to UEFI Spec Ruiyu Ni
2016-08-16  4:49   ` Gao, Liming [this message]
2016-08-10  5:56 ` [PATCH 02/11] MdeModulePkg: Add API ResetPlatformSpecific() to ResetSystemLib.h Ruiyu Ni
2016-08-10  5:56 ` [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific Ruiyu Ni
2016-08-23  3:21   ` Tian, Feng
2016-08-23  4:56     ` Ni, Ruiyu
2016-08-10  5:56 ` [PATCH 04/11] CorebootPayloadPkg/ResetSystemLib: " Ruiyu Ni
2016-08-11 16:09   ` Ma, Maurice
2016-08-10  5:56 ` [PATCH 05/11] OvmfPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10  5:56 ` [PATCH 06/11] PcAtChipsetPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10  5:56 ` [PATCH 07/11] QuarkSocPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10 16:28   ` Kinney, Michael D
2016-08-10  5:56 ` [PATCH 08/11] Vlv2TbltDevicePkg/ResetSystemLib: " Ruiyu Ni
2016-08-11  2:22   ` Wei, David
2016-08-10  5:56 ` [PATCH 09/11] OvmfPkg: Use MdeModulePkg/ResetSystemRuntimeDxe Ruiyu Ni
2016-08-10  5:56 ` [PATCH 10/11] PcAtChipsetPkg: Remove KbcResetDxe Ruiyu Ni
2016-08-10  5:56 ` [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific Ruiyu Ni
2016-08-10 17:33   ` Jordan Justen
2016-08-11  2:43     ` Ni, Ruiyu
2016-08-11  6:05       ` Jordan Justen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A1155EB7E4@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox