From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ml01.01.org (Postfix) with ESMTP id 44D6F1A1E05 for ; Thu, 18 Aug 2016 21:56:41 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 18 Aug 2016 21:56:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,543,1464678000"; d="scan'208";a="1038296741" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 18 Aug 2016 21:56:42 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Aug 2016 21:56:40 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Aug 2016 21:56:40 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Fri, 19 Aug 2016 12:56:37 +0800 From: "Gao, Liming" To: "Shi, Steven" , "edk2-devel@lists.01.org" CC: "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH v2] BaseTools-CLANG38: Add -O3 in DLINK2 flag Thread-Index: AQHR+cPtTMUBhLhnXEekSrJglY8Q26BPuHbA Date: Fri, 19 Aug 2016 04:56:37 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A1155ECDE7@shsmsx102.ccr.corp.intel.com> References: <1471574780-49732-1-git-send-email-steven.shi@intel.com> In-Reply-To: <1471574780-49732-1-git-send-email-steven.shi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] BaseTools-CLANG38: Add -O3 in DLINK2 flag X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 04:56:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Shi, Steven > Sent: Friday, August 19, 2016 10:46 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: ard.biesheuvel@linaro.org; Shi, Steven > Subject: [PATCH v2] BaseTools-CLANG38: Add -O3 in DLINK2 flag >=20 > CLANG38 build fail after CC_FLAG is added in the link rule. > This failure is because the CLANG38 enable the LTO through LLVMgold.so > linker plugin, but the LLVMgold.so plugin cannot accept the clang -Oz > CC flag as build option. After CC_FLAG is added in the link rule, > the LLVMgold.so plugin reports linking error. LLVMgold.so only accept > -O0 ~ -O3, and you can see it in the LLVM gold plugin source code > in below: >=20 > http://llvm.org/svn/llvm-project/llvm/tags/RELEASE_380/final/tools/gold/ > gold-plugin.cpp line173: >=20 > if (opt[1] < '0' || opt[1] > '3') > message(LDPL_FATAL, "Optimization level must be between 0 and 3"); >=20 > Add -O3 in the *_CLANG38_*_DLINK2_FLAGS to override the -Oz flag in > *_CLANG38_*_CC_FLAGS to pass LLVMgold.so linking. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Steven Shi > --- > BaseTools/Conf/tools_def.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 974656c..42a3ca0 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -5489,7 +5489,7 @@ DEFINE CLANG38_ALL_CC_FLAGS =3D > DEF(GCC44_ALL_CC_FLAGS) -Wno-empty-body -f > DEBUG_CLANG38_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > m32 -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) -g > RELEASE_CLANG38_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > m32 -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) > *_CLANG38_IA32_DLINK_FLAGS =3D DEF(GCC5_IA32_X64_DLINK_FLAGS) > -Wl,-Oz -Wl,-melf_i386 -Wl,--oformat=3Delf32-i386 > -*_CLANG38_IA32_DLINK2_FLAGS =3D DEF(GCC5_IA32_DLINK2_FLAGS) > +*_CLANG38_IA32_DLINK2_FLAGS =3D DEF(GCC5_IA32_DLINK2_FLAGS) - > O3 > *_CLANG38_IA32_RC_FLAGS =3D DEF(GCC_IA32_RC_FLAGS) > *_CLANG38_IA32_OBJCOPY_FLAGS =3D > *_CLANG38_IA32_NASM_FLAGS =3D -f elf32 > @@ -5518,7 +5518,7 @@ RELEASE_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto - > DEBUG_CLANG38_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > m64 "-DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall - > fpie -Oz -flto DEF(CLANG38_X64_TARGET) -g > RELEASE_CLANG38_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > m64 "-DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall - > fpie -Oz -flto DEF(CLANG38_X64_TARGET) > *_CLANG38_X64_DLINK_FLAGS =3D DEF(GCC5_IA32_X64_DLINK_FLAGS) - > Wl,-Oz -Wl,-melf_x86_64 -Wl,--oformat=3Delf64-x86-64 -Wl,-pie - > mcmodel=3Dsmall > -*_CLANG38_X64_DLINK2_FLAGS =3D DEF(GCC5_X64_DLINK2_FLAGS) > +*_CLANG38_X64_DLINK2_FLAGS =3D DEF(GCC5_X64_DLINK2_FLAGS) -O3 > *_CLANG38_X64_RC_FLAGS =3D DEF(GCC_X64_RC_FLAGS) > *_CLANG38_X64_OBJCOPY_FLAGS =3D > *_CLANG38_X64_NASM_FLAGS =3D -f elf64 > -- > 2.7.4