From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range
Date: Wed, 7 Sep 2016 01:56:44 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E2EDB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1472817558-234220-1-git-send-email-star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, September 02, 2016 7:59 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD
> SkuId range
>
> Current BaseTools follow previous PI spec to use UINT8 for SkuId, to
> follow PI1.4a, BaseTools need to be updated to fix artificial limitation
> of PCD SkuId range.
>
> BaseTools is updated to use UINT64 for SkuId, since the PCD database
> structure needs to be naturally aligned, the PCD database structure
> layout is adjusted to keep the natural alignment and version
> is updated to 6.
>
> The structure definition in MdeModulePkg/Include/Guid/
> PcdDataBaseSignatureGuid.h and PCD drivers are also updated to match
> BaseTools.
>
> Note: The source code and BaseTools need to be upgraded at the same time,
> and if they are not upgraded at the same time, build error like below will
> be triggered to help user identify the problem.
>
> "Please make sure the version of PCD PEIM Service and the generated
> PCD PEI Database match."
>
> Star Zeng (1):
> MdeModulePkg PCD: Update PCD database structure definition to match
> BaseTools
>
> Yonghong Zhu (1):
> BaseTools: Follow PI1.4a to fix artificial limitation of PCD SkuId
> range
>
> BaseTools/Source/Python/AutoGen/GenPcdDb.py | 91
> ++++++++++++++--------
> .../Include/Guid/PcdDataBaseSignatureGuid.h | 14 ++--
> MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 2 +-
> MdeModulePkg/Universal/PCD/Dxe/Service.c | 2 +-
> MdeModulePkg/Universal/PCD/Dxe/Service.h | 4 +-
> MdeModulePkg/Universal/PCD/Pei/Pcd.c | 2 +-
> MdeModulePkg/Universal/PCD/Pei/Service.c | 4 +-
> MdeModulePkg/Universal/PCD/Pei/Service.h | 4 +-
> 8 files changed, 73 insertions(+), 50 deletions(-)
>
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-07 1:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 11:59 [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range Star Zeng
2016-09-02 11:59 ` [PATCH 1/2] BaseTools: " Star Zeng
2016-09-02 11:59 ` [PATCH 2/2] MdeModulePkg PCD: Update PCD database structure definition to match BaseTools Star Zeng
2016-09-07 1:56 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B3E2EDB@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox