public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v3 0/3] MdePkg: add ARM/AARCH64 support to BaseMemoryLib
Date: Wed, 7 Sep 2016 07:16:09 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E30EF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1473230862-20689-1-git-send-email-ard.biesheuvel@linaro.org>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, September 07, 2016 2:48 PM
> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming
> <liming.gao@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>
> Subject: [PATCH v3 0/3] MdePkg: add ARM/AARCH64 support to
> BaseMemoryLib
> 
> This adds ARM and AARCH64 support to both BaseMemoryLib (generic C)
> and
> BaseMemoryLibOptDxe (accelerated). The former can be used anywhere,
> the
> latter only in places where the caches are guaranteed to be on, not only
> due to the unaligned accesses but also due to the fact that it uses
> DC ZVA instructions for clearing memory (AArch64 only).
> 
> Changes since v2:
> - avoid open coded 64-bit shift (#1)
> - tweak SetMem implementation (#2)
> 
> Ard Biesheuvel (3):
>   MdePkg/BaseMemoryLib: widen aligned accesses to 32 or 64 bits
>   MdePkg/BaseMemoryLibOptDxe: add accelerated ARM routines
>   MdePkg/BaseMemoryLibOptDxe: add accelerated AARCH64 routines
> 
>  MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf             |   2 +-
>  MdePkg/Library/BaseMemoryLib/CopyMem.c                     | 112 +++++++-
>  MdePkg/Library/BaseMemoryLib/SetMem.c                      |  40 ++-
>  MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareMem.S    | 142
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CopyMem.S       | 284
> ++++++++++++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/AArch64/ScanMem.S       | 161
> +++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/AArch64/SetMem.S        | 244
> +++++++++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S        | 138
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.asm      | 140
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S           | 172
> ++++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.asm         | 147
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/ScanMem.S           | 146
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/ScanMem.asm         | 147
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/ScanMemGeneric.c    | 142
> ++++++++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S            |  67 +++++
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.asm          |  74
> +++++
>  MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf |  37
> ++-
>  17 files changed, 2167 insertions(+), 28 deletions(-)
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CopyMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/AArch64/ScanMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/AArch64/SetMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.asm
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.asm
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/ScanMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/ScanMem.asm
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/ScanMemGeneric.c
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S
>  create mode 100644
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.asm
> 
> --
> 2.7.4



      parent reply	other threads:[~2016-09-07  7:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  6:47 [PATCH v3 0/3] MdePkg: add ARM/AARCH64 support to BaseMemoryLib Ard Biesheuvel
2016-09-07  6:47 ` [PATCH v3 1/3] MdePkg/BaseMemoryLib: widen aligned accesses to 32 or 64 bits Ard Biesheuvel
2016-09-07  6:47 ` [PATCH v3 2/3] MdePkg/BaseMemoryLibOptDxe: add accelerated ARM routines Ard Biesheuvel
2016-09-07  6:47 ` [PATCH v3 3/3] MdePkg/BaseMemoryLibOptDxe: add accelerated AARCH64 routines Ard Biesheuvel
2016-09-07  7:16 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B3E30EF@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox