From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26DCF1A1DFE for ; Fri, 9 Sep 2016 00:25:49 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 09 Sep 2016 00:25:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,304,1470726000"; d="scan'208";a="6255786" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 09 Sep 2016 00:25:48 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 9 Sep 2016 00:25:48 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 9 Sep 2016 00:25:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0248.002; Fri, 9 Sep 2016 15:25:45 +0800 From: "Gao, Liming" To: Laszlo Ersek , edk2-devel-01 CC: Ard Biesheuvel , "Zhu, Yonghong" Thread-Topic: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup strings Thread-Index: AQHSCmss5xynh0s4kk2h2zJofJVvmaBwweKQ Date: Fri, 9 Sep 2016 07:25:45 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E63EF@shsmsx102.ccr.corp.intel.com> References: <20160909072356.4746-1-lersek@redhat.com> In-Reply-To: <20160909072356.4746-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup strings X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 07:25:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Friday, September 09, 2016 3:24 PM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Gao, Liming > ; Zhu, Yonghong > Subject: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup > strings >=20 > "EfiRom --dump" does not recognize the 0x8664 machine type: >=20 > > EFI ROM header contents > > EFI Signature 0x0EF1 > > Compression Type 0x0001 (compressed) > > Machine type 0x8664 (unknown) > > Subsystem 0x000B (EFI boot service driver) > > EFI image offset 0x0050 (@0xF650) >=20 > Add lookup strings for the remaining EFI_IMAGE_MACHINE_* numeric > macros > that can be found in > "BaseTools/Source/C/Include/IndustryStandard/PeImage.h". The strings > follow Table 12. "UEFI Image Types" from the UEFI v2.6 spec. >=20 > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > v2: > - use ARM for ARM [Ard, Liming] > - use AA64 for AARCH64 [Liming] > - reference Table 12 in the commit message [Liming] >=20 > BaseTools/Source/C/EfiRom/EfiRom.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/BaseTools/Source/C/EfiRom/EfiRom.h > b/BaseTools/Source/C/EfiRom/EfiRom.h > index 1214700826de..6763d6b1ec28 100644 > --- a/BaseTools/Source/C/EfiRom/EfiRom.h > +++ b/BaseTools/Source/C/EfiRom/EfiRom.h > @@ -117,6 +117,9 @@ static STRING_LOOKUP mMachineTypes[] =3D { > { EFI_IMAGE_MACHINE_IA32, "IA32" }, > { EFI_IMAGE_MACHINE_IA64, "IA64" }, > { EFI_IMAGE_MACHINE_EBC, "EBC" }, > + { EFI_IMAGE_MACHINE_X64, "X64" }, > + { EFI_IMAGE_MACHINE_ARMT, "ARM" }, > + { EFI_IMAGE_MACHINE_AARCH64, "AA64" }, > { 0, NULL } > }; >=20 > -- > 2.9.2