From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 406BD1A1DF1 for ; Sun, 11 Sep 2016 19:35:47 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 11 Sep 2016 19:35:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,320,1470726000"; d="scan'208";a="1048913629" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 11 Sep 2016 19:35:46 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 11 Sep 2016 19:35:44 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 11 Sep 2016 19:35:43 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.91]) with mapi id 14.03.0248.002; Mon, 12 Sep 2016 10:35:40 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [patch] MdeModulePkg/UiApp: Fix incorrect question id Thread-Index: AQHSCbDavPWXqSqinkmCmODaKi4+qKB1KU+Q Date: Mon, 12 Sep 2016 02:35:40 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E6C9C@shsmsx102.ccr.corp.intel.com> References: <1473325798-24284-1-git-send-email-dandan.bi@intel.com> <1473325798-24284-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1473325798-24284-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/UiApp: Fix incorrect question id X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 02:35:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, September 08, 2016 5:10 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix incorrect question id >=20 > For a question, its question id can not be zero. > This patch is to fix the issue that using zero as question id. >=20 > Cc: Liming Gao > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 3 > ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git > a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > index 93f6e4e..1505ef9 100644 > --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > +++ > b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > @@ -41,10 +41,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF > ANY KIND, EITHER EXPRESS OR IMPLIED. > #define UI_HII_DRIVER_LIST_SIZE 0x8 >=20 > #define FRONT_PAGE_KEY_CONTINUE 0x1000 > #define FRONT_PAGE_KEY_RESET 0x1001 > #define FRONT_PAGE_KEY_LANGUAGE 0x1002 > +#define FRONT_PAGE_KEY_DRIVER 0x2000 >=20 > typedef struct { > EFI_STRING_ID PromptId; > EFI_STRING_ID HelpId; > EFI_STRING_ID DevicePathId; > @@ -654,11 +655,11 @@ UiListThirdPartyDrivers ( > StartOpCodeHandle, > 0, > gHiiDriverList[Index].PromptId, > gHiiDriverList[Index].HelpId, > 0, > - 0, > + (EFI_QUESTION_ID) (Index + FRONT_PAGE_KEY_DRIVER), > 0, > &gHiiDriverList[Index].FormSetGuid, > gHiiDriverList[Index].DevicePathId > ); >=20 > -- > 1.9.5.msysgit.1