public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Wu, Hao A" <hao.a.wu@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"vishalo@qti.qualcomm.com" <vishalo@qti.qualcomm.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s
Date: Wed, 21 Sep 2016 01:27:59 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47AFDD@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu-rieXsPt0pVrqKxWzQoKtMeb1bTZpOdxkmjs83pBLuNA@mail.gmail.com>

Ard:
   Thanks!  Other two patches are good. Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks
Liming
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Tuesday, September 20, 2016 8:41 PM
To: Wu, Hao A <hao.a.wu@intel.com>
Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; vishalo@qti.qualcomm.com; leif.lindholm@linaro.org
Subject: Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

On 20 September 2016 at 13:16, Ard Biesheuvel wrote:
> On 20 September 2016 at 13:02, Wu, Hao A wrote:
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard
>>> Biesheuvel
>>> Sent: Tuesday, September 20, 2016 4:38 PM
>>> To: Wu, Hao A
>>> Cc: leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>;
>>> vishalo@qti.qualcomm.com<mailto:vishalo@qti.qualcomm.com>; Gao, Liming
>>> Subject: Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing
>>> ASSERT()s
>>>
>>> On 20 September 2016 at 03:00, Wu, Hao A wrote:
>>> > Hi Ard,
>>> >
>>> > The NULL checks for the input Guids in APIs CopyGuid(), CompareGuid() and
>>> > IsZeroGuid() are implicitly done within calls to BaseLib APIs
>>> > ReadUnaligned64() and WriteUnaligned64().
>>> >
>>> > So I think the functions behavior matches with their comments. What do you
>>> > think?
>>> >
>>>
>>> I disagree. ReadUnaligned64 and WriteUnaligned64 could theoretically
>>> be implemented by a version of BaseLib that does not contain such
>>> ASSERT()s
>>
>> The comments for APIs ReadUnaligned64 and WriteUnaligned64 in BaseLib
>> mention the ASSERT() for inputting a NULL buffer.
>>
>> I think instances of BaseLib should follow the comments.
>>
>
> I agree with this. But that does not justify omitting them here.

... but actually, it makes no sense to argue about this, since the
user visible outcome is the same. I will withdraw the patch.

Thanks,
Ard.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-09-21  1:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19  8:13 [PATCH v2 0/3] MdePkg/BaseMemoryLibOptDxe: generic and ARM/AARCH64 fixes Ard Biesheuvel
2016-09-19  8:13 ` [PATCH v2 1/3] MdePkg/BaseMemoryLibOptDxe ARM: fix arithmetic bugs in CompareMem() Ard Biesheuvel
2016-09-19  8:13 ` [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s Ard Biesheuvel
2016-09-20  2:00   ` Wu, Hao A
2016-09-20  8:38     ` Ard Biesheuvel
2016-09-20 12:02       ` Wu, Hao A
2016-09-20 12:16         ` Ard Biesheuvel
2016-09-20 12:40           ` Ard Biesheuvel
2016-09-21  1:27             ` Gao, Liming [this message]
2016-09-19  8:13 ` [PATCH v2 3/3] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: implement accelerated GUID functions Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B47AFDD@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox