From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 115881A1DFF for ; Tue, 20 Sep 2016 18:28:03 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 20 Sep 2016 18:28:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,371,1470726000"; d="scan'208,217";a="763915624" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 20 Sep 2016 18:28:04 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 18:28:02 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 18:28:02 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0248.002; Wed, 21 Sep 2016 09:28:00 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "Wu, Hao A" CC: "edk2-devel@lists.01.org" , "vishalo@qti.qualcomm.com" , "leif.lindholm@linaro.org" Thread-Topic: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s Thread-Index: AQHSEk3RhXBBATx4nUm1TBZI9GICqaCBGrkAgABvQgCAADj9AIAAA9eAgAAG54CAAVxI8A== Date: Wed, 21 Sep 2016 01:27:59 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47AFDD@shsmsx102.ccr.corp.intel.com> References: <1474272831-20840-1-git-send-email-ard.biesheuvel@linaro.org> <1474272831-20840-3-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 01:28:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: Thanks! Other two patches are good. Reviewed-by: Liming Gao Thanks Liming From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard = Biesheuvel Sent: Tuesday, September 20, 2016 8:41 PM To: Wu, Hao A Cc: edk2-devel@lists.01.org; Gao, Liming ; vishalo@qt= i.qualcomm.com; leif.lindholm@linaro.org Subject: Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSER= T()s On 20 September 2016 at 13:16, Ard Biesheuvel wrote: > On 20 September 2016 at 13:02, Wu, Hao A wrote: >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of = Ard >>> Biesheuvel >>> Sent: Tuesday, September 20, 2016 4:38 PM >>> To: Wu, Hao A >>> Cc: leif.lindholm@linaro.org; edk2-dev= el@lists.01.org; >>> vishalo@qti.qualcomm.com; Gao, Liming >>> Subject: Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing >>> ASSERT()s >>> >>> On 20 September 2016 at 03:00, Wu, Hao A wrote: >>> > Hi Ard, >>> > >>> > The NULL checks for the input Guids in APIs CopyGuid(), CompareGuid()= and >>> > IsZeroGuid() are implicitly done within calls to BaseLib APIs >>> > ReadUnaligned64() and WriteUnaligned64(). >>> > >>> > So I think the functions behavior matches with their comments. What d= o you >>> > think? >>> > >>> >>> I disagree. ReadUnaligned64 and WriteUnaligned64 could theoretically >>> be implemented by a version of BaseLib that does not contain such >>> ASSERT()s >> >> The comments for APIs ReadUnaligned64 and WriteUnaligned64 in BaseLib >> mention the ASSERT() for inputting a NULL buffer. >> >> I think instances of BaseLib should follow the comments. >> > > I agree with this. But that does not justify omitting them here. ... but actually, it makes no sense to argue about this, since the user visible outcome is the same. I will withdraw the patch. Thanks, Ard. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel