From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA9BD1A1EC7 for ; Wed, 21 Sep 2016 19:49:27 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 21 Sep 2016 19:49:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,376,1470726000"; d="scan'208";a="1043981650" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 21 Sep 2016 19:49:27 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 19:49:27 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 19:49:27 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Thu, 22 Sep 2016 10:49:23 +0800 From: "Gao, Liming" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Dong, Eric" Thread-Topic: [edk2] [Patch] MdeModulePkg FormBrowserEx: Change its structure name with EDKII_ prefix Thread-Index: AQHSFHXPP6rU+txcbk6WgY0A6/3swaCER4GAgACHBRA= Date: Thu, 22 Sep 2016 02:49:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47B9D2@shsmsx102.ccr.corp.intel.com> References: <1474509892-12568-1-git-send-email-liming.gao@intel.com> <0C09AFA07DD0434D9E2A0C6AEB04831039564757@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB04831039564757@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg FormBrowserEx: Change its structure name with EDKII_ prefix X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 02:49:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good comments. GuidCName should be changed to align its C definition, and k= eep gEfiFormBrowserExProtocolGuid for compatibility.=20 Thanks Liming > -----Original Message----- > From: Zeng, Star > Sent: Thursday, September 22, 2016 10:45 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Tian, Feng ; Dong, Eric ; > Zeng, Star > Subject: RE: [edk2] [Patch] MdeModulePkg FormBrowserEx: Change its > structure name with EDKII_ prefix >=20 > Is there change needed to gEfiFormBrowserExProtocolGuid in > FormBrowserEx.h and MdeModulePkg.dec? >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, September 22, 2016 10:05 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Dong, Eric > Subject: [edk2] [Patch] MdeModulePkg FormBrowserEx: Change its > structure name with EDKII_ prefix >=20 > EDKII implementation protocol should be with EDKII_ prefix. >=20 > Cc: Eric Dong > Cc: Feng Tian > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > MdeModulePkg/Include/Protocol/FormBrowserEx.h | 11 ++++++++--- > MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 2 +- > MdeModulePkg/Universal/SetupBrowserDxe/Setup.h | 2 +- > 3 files changed, 10 insertions(+), 5 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > index ef3e8cb..06ca50b 100644 > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > @@ -2,7 +2,7 @@ > Extension Form Browser Protocol provides the services that can be used= to > register the different hot keys for the standard Browser actions descr= ibed > in UEFI specification. >=20 > -Copyright (c) 2011 - 2014, Intel Corporation. All rights reserved.
> +Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License that > accompanies this distribution. > The full text of the license may be found at @@ -19,7 +19,12 @@ WITHOUT > WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > #define FORM_BROWSER_EXTENSION_PROTOCOL_GUID \ > { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x= 7d, > 0xa4 } } >=20 > -typedef struct _EFI_FORM_BROWSER_EXTENSION_PROTOCOL > EFI_FORM_BROWSER_EXTENSION_PROTOCOL; > +typedef struct _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL > EDKII_FORM_BROWSER_EXTENSION_PROTOCOL; > + > +// > +// To be compatible, keep EFI_FORM_BROWSER_EXTENSION_PROTOCOL > +definition // > +typedef EDKII_FORM_BROWSER_EXTENSION_PROTOCOL > EFI_FORM_BROWSER_EXTENSION_PROTOCOL; >=20 > // > // Return value of SAVE_REMINDER() that describes whether the changed > data is saved or discarded. > @@ -137,7 +142,7 @@ UINT32 > VOID > ); >=20 > -struct _EFI_FORM_BROWSER_EXTENSION_PROTOCOL { > +struct _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL { > SET_SCOPE SetScope; > REGISTER_HOT_KEY RegisterHotKey; > REGISTER_EXIT_HANDLER RegiserExitHandler; diff --git > a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > index ea6b124..a52c577 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > @@ -1952,7 +1952,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; >=20 > // > // Initialize the local variables. > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h > index cbc5401..cc9f431 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h > @@ -90,7 +90,7 @@ typedef struct { > // Produced protocol > // > EFI_FORM_BROWSER2_PROTOCOL FormBrowser2; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL FormBrowserEx; >=20 > EDKII_FORM_BROWSER_EXTENSION2_PROTOCOL FormBrowserEx2; >=20 > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel