public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: handling the case that map file is not exist
Date: Fri, 23 Sep 2016 01:36:34 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47BEB0@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1474552607-6312-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, September 22, 2016 9:57 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: handling the case that map file is not exist
> 
> We meet a case that add the library inf file which has the uni file in
> the [Sources] section, for this case there will no map file exist, it
> cause build tools report Traceback  error.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/GenFds/FfsInfStatement.py | 33
> ++++++++++++-----------
>  1 file changed, 17 insertions(+), 16 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> b/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> index b0b22d1..e9517a4 100644
> --- a/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> +++ b/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> @@ -939,26 +939,27 @@ class FfsInfStatement(FfsInfStatementClassObject):
>                  if len(VfrUniBaseName) > 0:
>                      VfrUniOffsetList =
> self.__GetBuildOutputMapFileVfrUniInfo(VfrUniBaseName)
>                      #
>                      # Generate the Raw data of raw section
>                      #
> -                    os.path.join( self.OutputPath, self.BaseName + '.offset')
> -                    UniVfrOffsetFileName    =  os.path.join( self.OutputPath,
> self.BaseName + '.offset')
> -                    UniVfrOffsetFileSection =  os.path.join( self.OutputPath,
> self.BaseName + 'Offset' + '.raw')
> -
> -                    self.__GenUniVfrOffsetFile (VfrUniOffsetList,
> UniVfrOffsetFileName)
> -
> -                    UniVfrOffsetFileNameList = []
> -                    UniVfrOffsetFileNameList.append(UniVfrOffsetFileName)
> -                    """Call GenSection"""
> -                    GenFdsGlobalVariable.GenerateSection(UniVfrOffsetFileSection,
> -                                                         UniVfrOffsetFileNameList,
> -                                                         "EFI_SECTION_RAW"
> -                                                         )
> -                    os.remove(UniVfrOffsetFileName)
> -                    SectList.append(UniVfrOffsetFileSection)
> -                    HasGneratedFlag = True
> +                    if VfrUniOffsetList:
> +                        os.path.join( self.OutputPath, self.BaseName + '.offset')
> +                        UniVfrOffsetFileName    =  os.path.join( self.OutputPath,
> self.BaseName + '.offset')
> +                        UniVfrOffsetFileSection =  os.path.join( self.OutputPath,
> self.BaseName + 'Offset' + '.raw')
> +
> +                        self.__GenUniVfrOffsetFile (VfrUniOffsetList,
> UniVfrOffsetFileName)
> +
> +                        UniVfrOffsetFileNameList = []
> +                        UniVfrOffsetFileNameList.append(UniVfrOffsetFileName)
> +                        """Call GenSection"""
> +
> GenFdsGlobalVariable.GenerateSection(UniVfrOffsetFileSection,
> +                                                             UniVfrOffsetFileNameList,
> +                                                             "EFI_SECTION_RAW"
> +                                                             )
> +                        os.remove(UniVfrOffsetFileName)
> +                        SectList.append(UniVfrOffsetFileSection)
> +                        HasGneratedFlag = True
> 
>              for SecName in  SectList :
>                  SectFiles.append(SecName)
>                  SectAlignments.append(Align)
>              Index = Index + 1
> --
> 2.6.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2016-09-23  1:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 13:56 [Patch] BaseTools: handling the case that map file is not exist Yonghong Zhu
2016-09-23  1:36 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B47BEB0@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox