From: "Gao, Liming" <liming.gao@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 00/13] Add HiiImageEx implementation and demonstrate in Nt32
Date: Mon, 26 Sep 2016 02:55:23 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47CCEE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20160923082521.99872-1-ruiyu.ni@intel.com>
Ray:
I have some comments.
1) This is the incompatible change in BootLogoLib. It also impacts OvmfPkg and ArmVirtPkg. Please highlight this change in cover letter, and update OvmfPkg and ArmVirtPkg both.
2) HiiDrawImageIdEx() directly calls HiiDrawImageId(). But, HiiDrawImageId() doesn't support JPEG and PNG. This is a functional issue in HiiDrawImageIdEx().
3) IGetImage() will call Decoder protocol to get the output ImageOut. Per UEFI spec, ImageOut is allocated by Decoder protocol, and free by the caller. Please free it in IGetImage()
Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Friday, September 23, 2016 4:25 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 00/13] Add HiiImageEx implementation and
> demonstrate in Nt32
>
> The total 13 commits can be reviewed in following url:
> https://github.com/niruiyu/edk2/commits/HiiImage
>
> Ruiyu Ni (13):
> MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress
> MdeModulePkg/HiiDatabase: Move common code to LocatePackageList()
> MdeModulePkg/HiiDatabase: Refine HiiNewImage()
> MdeModulePkg/HiiDatabase: Refine HiiGetImage()
> MdeModulePkg/HiiDatabase: Refine HiiSetImage()
> MdeModulePkg/HiiDatabase: Refine HiiDrawImage()
> MdemodulePkg/HiiDatabase: Correct typo in comments.
> MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG
> MdeModulePkg/HiiDatabase: Add HiiImageEx implementation.
> Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo
> MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in
> parameters
> MdeModulePkg/Logo: Add LogoDxe module
> Nt32Pkg: Use the new LogoDxe driver
>
> MdeModulePkg/Include/Library/BootLogoLib.h | 19 +-
> MdeModulePkg/Include/Protocol/PlatformLogo.h | 18 +-
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 204 +++----
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 6 +-
> MdeModulePkg/Logo/Logo.c | 156 ++++++
> MdeModulePkg/Logo/Logo.idf | 18 +
> MdeModulePkg/Logo/LogoDxe.inf | 60 ++
> MdeModulePkg/Logo/LogoDxe.uni | 21 +
> MdeModulePkg/Logo/LogoDxeExtra.uni | 19 +
> .../HiiDatabaseDxe/ConfigKeywordHandler.c | 36 +-
> .../Universal/HiiDatabaseDxe/ConfigRouting.c | 58 +-
> MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 16 +-
> MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 32 +-
> .../Universal/HiiDatabaseDxe/HiiDatabase.h | 292 +++++++++-
> .../Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 7 +-
> .../Universal/HiiDatabaseDxe/HiiDatabaseEntry.c | 34 +-
> MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 619 ++++++++++---
> --------
> MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c | 397
> +++++++++++++
> .../PlatformBootManagerLib/PlatformBootManager.c | 4 +-
> Nt32Pkg/Nt32Pkg.dsc | 7 +-
> Nt32Pkg/Nt32Pkg.fdf | 5 +-
> 21 files changed, 1432 insertions(+), 596 deletions(-)
> create mode 100644 MdeModulePkg/Logo/Logo.c
> create mode 100644 MdeModulePkg/Logo/Logo.idf
> create mode 100644 MdeModulePkg/Logo/LogoDxe.inf
> create mode 100644 MdeModulePkg/Logo/LogoDxe.uni
> create mode 100644 MdeModulePkg/Logo/LogoDxeExtra.uni
> create mode 100644 MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c
>
> --
> 2.9.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-26 2:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 8:25 [PATCH 00/13] Add HiiImageEx implementation and demonstrate in Nt32 Ruiyu Ni
2016-09-23 8:25 ` [PATCH 01/13] MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress Ruiyu Ni
2016-09-23 8:25 ` [PATCH 02/13] MdeModulePkg/HiiDatabase: Move common code to LocatePackageList() Ruiyu Ni
2016-09-23 8:25 ` [PATCH 03/13] MdeModulePkg/HiiDatabase: Refine HiiNewImage() Ruiyu Ni
2016-09-23 8:25 ` [PATCH 04/13] MdeModulePkg/HiiDatabase: Refine HiiGetImage() Ruiyu Ni
2016-09-23 8:25 ` [PATCH 05/13] MdeModulePkg/HiiDatabase: Refine HiiSetImage() Ruiyu Ni
2016-09-23 8:25 ` [PATCH 06/13] MdeModulePkg/HiiDatabase: Refine HiiDrawImage() Ruiyu Ni
2016-09-23 8:25 ` [PATCH 07/13] MdemodulePkg/HiiDatabase: Correct typo in comments Ruiyu Ni
2016-09-23 8:25 ` [PATCH 08/13] MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG Ruiyu Ni
2016-09-23 8:25 ` [PATCH 09/13] MdeModulePkg/HiiDatabase: Add HiiImageEx implementation Ruiyu Ni
2016-09-23 8:25 ` [PATCH 10/13] Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo Ruiyu Ni
2016-09-23 8:25 ` [PATCH 11/13] MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in parameters Ruiyu Ni
2016-09-23 8:25 ` [PATCH 12/13] MdeModulePkg/Logo: Add LogoDxe module Ruiyu Ni
2016-09-23 8:25 ` [PATCH 13/13] Nt32Pkg: Use the new LogoDxe driver Ruiyu Ni
2016-09-26 2:55 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B47CCEE@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox