From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 900781A1DFC for ; Sun, 25 Sep 2016 19:55:28 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 25 Sep 2016 19:55:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,397,1470726000"; d="scan'208";a="883716792" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 25 Sep 2016 19:55:27 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Sep 2016 19:55:27 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Mon, 26 Sep 2016 10:55:24 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 00/13] Add HiiImageEx implementation and demonstrate in Nt32 Thread-Index: AQHSFXQOtrSHkBKJlUe/cLp2sOh/waCLFo2A Date: Mon, 26 Sep 2016 02:55:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47CCEE@shsmsx102.ccr.corp.intel.com> References: <20160923082521.99872-1-ruiyu.ni@intel.com> In-Reply-To: <20160923082521.99872-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 00/13] Add HiiImageEx implementation and demonstrate in Nt32 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 02:55:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray: I have some comments.=20 1) This is the incompatible change in BootLogoLib. It also impacts OvmfPkg = and ArmVirtPkg. Please highlight this change in cover letter, and update Ov= mfPkg and ArmVirtPkg both. 2) HiiDrawImageIdEx() directly calls HiiDrawImageId(). But, HiiDrawImageId(= ) doesn't support JPEG and PNG. This is a functional issue in HiiDrawImageI= dEx().=20 3) IGetImage() will call Decoder protocol to get the output ImageOut. Per U= EFI spec, ImageOut is allocated by Decoder protocol, and free by the caller= . Please free it in IGetImage() Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, September 23, 2016 4:25 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 00/13] Add HiiImageEx implementation and > demonstrate in Nt32 >=20 > The total 13 commits can be reviewed in following url: > https://github.com/niruiyu/edk2/commits/HiiImage >=20 > Ruiyu Ni (13): > MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress > MdeModulePkg/HiiDatabase: Move common code to LocatePackageList() > MdeModulePkg/HiiDatabase: Refine HiiNewImage() > MdeModulePkg/HiiDatabase: Refine HiiGetImage() > MdeModulePkg/HiiDatabase: Refine HiiSetImage() > MdeModulePkg/HiiDatabase: Refine HiiDrawImage() > MdemodulePkg/HiiDatabase: Correct typo in comments. > MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG > MdeModulePkg/HiiDatabase: Add HiiImageEx implementation. > Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo > MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in > parameters > MdeModulePkg/Logo: Add LogoDxe module > Nt32Pkg: Use the new LogoDxe driver >=20 > MdeModulePkg/Include/Library/BootLogoLib.h | 19 +- > MdeModulePkg/Include/Protocol/PlatformLogo.h | 18 +- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 204 +++---- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 6 +- > MdeModulePkg/Logo/Logo.c | 156 ++++++ > MdeModulePkg/Logo/Logo.idf | 18 + > MdeModulePkg/Logo/LogoDxe.inf | 60 ++ > MdeModulePkg/Logo/LogoDxe.uni | 21 + > MdeModulePkg/Logo/LogoDxeExtra.uni | 19 + > .../HiiDatabaseDxe/ConfigKeywordHandler.c | 36 +- > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 58 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 16 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 32 +- > .../Universal/HiiDatabaseDxe/HiiDatabase.h | 292 +++++++++- > .../Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 7 +- > .../Universal/HiiDatabaseDxe/HiiDatabaseEntry.c | 34 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 619 ++++++++++--- > -------- > MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c | 397 > +++++++++++++ > .../PlatformBootManagerLib/PlatformBootManager.c | 4 +- > Nt32Pkg/Nt32Pkg.dsc | 7 +- > Nt32Pkg/Nt32Pkg.fdf | 5 +- > 21 files changed, 1432 insertions(+), 596 deletions(-) > create mode 100644 MdeModulePkg/Logo/Logo.c > create mode 100644 MdeModulePkg/Logo/Logo.idf > create mode 100644 MdeModulePkg/Logo/LogoDxe.inf > create mode 100644 MdeModulePkg/Logo/LogoDxe.uni > create mode 100644 MdeModulePkg/Logo/LogoDxeExtra.uni > create mode 100644 MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c >=20 > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel