From: "Gao, Liming" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type
Date: Tue, 27 Sep 2016 01:31:08 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47D2AC@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1474878806-98772-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, September 26, 2016 4:33 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type
>
> The type of variable "SmallestIdFromFlag" should be BOOLEAN,
> this patch fix the incorrect type.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index 9f036a5..b223300 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2101,11 +2101,11 @@ ParseIfrData (
> LIST_ENTRY *LinkDefault;
> EFI_IFR_VARSTORE_NAME_VALUE *IfrNameValueVarStore;
> EFI_HII_PACKAGE_HEADER *PackageHeader;
> EFI_VARSTORE_ID VarStoreId;
> UINT16 SmallestDefaultId;
> - UINT16 SmallestIdFromFlag;
> + BOOLEAN SmallestIdFromFlag;
> BOOLEAN FromOtherDefaultOpcode;
>
> Status = EFI_SUCCESS;
> BlockData = NULL;
> DefaultDataPtr = NULL;
> --
> 1.9.5.msysgit.1
prev parent reply other threads:[~2016-09-27 1:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 8:33 [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type Dandan Bi
2016-09-27 1:31 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B47D2AC@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox