* [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type
@ 2016-09-26 8:33 Dandan Bi
2016-09-27 1:31 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2016-09-26 8:33 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Eric Dong
The type of variable "SmallestIdFromFlag" should be BOOLEAN,
this patch fix the incorrect type.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
index 9f036a5..b223300 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
@@ -2101,11 +2101,11 @@ ParseIfrData (
LIST_ENTRY *LinkDefault;
EFI_IFR_VARSTORE_NAME_VALUE *IfrNameValueVarStore;
EFI_HII_PACKAGE_HEADER *PackageHeader;
EFI_VARSTORE_ID VarStoreId;
UINT16 SmallestDefaultId;
- UINT16 SmallestIdFromFlag;
+ BOOLEAN SmallestIdFromFlag;
BOOLEAN FromOtherDefaultOpcode;
Status = EFI_SUCCESS;
BlockData = NULL;
DefaultDataPtr = NULL;
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type
2016-09-26 8:33 [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type Dandan Bi
@ 2016-09-27 1:31 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2016-09-27 1:31 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Dong, Eric
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, September 26, 2016 4:33 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type
>
> The type of variable "SmallestIdFromFlag" should be BOOLEAN,
> this patch fix the incorrect type.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index 9f036a5..b223300 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2101,11 +2101,11 @@ ParseIfrData (
> LIST_ENTRY *LinkDefault;
> EFI_IFR_VARSTORE_NAME_VALUE *IfrNameValueVarStore;
> EFI_HII_PACKAGE_HEADER *PackageHeader;
> EFI_VARSTORE_ID VarStoreId;
> UINT16 SmallestDefaultId;
> - UINT16 SmallestIdFromFlag;
> + BOOLEAN SmallestIdFromFlag;
> BOOLEAN FromOtherDefaultOpcode;
>
> Status = EFI_SUCCESS;
> BlockData = NULL;
> DefaultDataPtr = NULL;
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-27 1:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 8:33 [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type Dandan Bi
2016-09-27 1:31 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox