From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA3FF1A1E0F for ; Mon, 26 Sep 2016 18:31:13 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP; 26 Sep 2016 18:31:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,402,1470726000"; d="scan'208";a="13622778" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 26 Sep 2016 18:31:13 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 26 Sep 2016 18:31:13 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 26 Sep 2016 18:31:13 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Tue, 27 Sep 2016 09:31:09 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type Thread-Index: AQHSF9DLWH7F8dNNZ0m+N7F6GNz616CMjb+w Date: Tue, 27 Sep 2016 01:31:08 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47D2AC@shsmsx102.ccr.corp.intel.com> References: <1474878806-98772-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1474878806-98772-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 01:31:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Monday, September 26, 2016 4:33 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable t= ype >=20 > The type of variable "SmallestIdFromFlag" should be BOOLEAN, > this patch fix the incorrect type. >=20 > Cc: Liming Gao > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > index 9f036a5..b223300 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > @@ -2101,11 +2101,11 @@ ParseIfrData ( > LIST_ENTRY *LinkDefault; > EFI_IFR_VARSTORE_NAME_VALUE *IfrNameValueVarStore; > EFI_HII_PACKAGE_HEADER *PackageHeader; > EFI_VARSTORE_ID VarStoreId; > UINT16 SmallestDefaultId; > - UINT16 SmallestIdFromFlag; > + BOOLEAN SmallestIdFromFlag; > BOOLEAN FromOtherDefaultOpcode; >=20 > Status =3D EFI_SUCCESS; > BlockData =3D NULL; > DefaultDataPtr =3D NULL; > -- > 1.9.5.msysgit.1