Re: [PATCH 0/4] Show test key info on front page

["Gao, Liming" <liming.gao@intel.com>]

Jiewen:
  If the test key file is not built into BIOS image, BIOS code can't verify the key is test key or not. I understand PcdTestKeyUsed high bit is designed for this case. But, I don't find UiApp logic to handle it. 

  Besides, could we find one common header to define BITS for PcdTestKeyUsed? If so, you don't need to define them in every module. 

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jiewen Yao
> Sent: Sunday, October 09, 2016 7:58 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/4] Show test key info on front page
> 
> This series patch supports to show the test key information
> on the front page.
> PcdTestKeyUsed is added to MdeModulePkg.
> 
> This PCD can be set by platform to indicate if there is any
> test key used in current BIOS, such as recovery key,
> or capsule update key.
> Then the generic UI may consume this PCD to show warning information.
> 
> Jiewen Yao (4):
>   MdeModulePkg/dec: Add PcdTestKeyUsed PCD.
>   MdeModulePkg/UiApp: Show test key warning info in FrontPage.
>   QuarkPlatformPkg/Bds: Produce PcdTestKeyUsed.
>   Vlv2TbleDevicePkg/Bds: Produce PcdTestKeyUsed.
> 
>  MdeModulePkg/Application/UiApp/FrontPageCustomizedUi.c                     |
> 34 ++++++++++++++++++++
>  MdeModulePkg/Application/UiApp/FrontPageStrings.uni                        |  8
> ++++-
>  MdeModulePkg/Application/UiApp/UiApp.inf                                   |  3 +-
>  MdeModulePkg/MdeModulePkg.dec                                              | 11 +++++++
> 
> QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.
> c      | 11 +++++++
> 
> QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.
> h      |  5 +++
> 
> QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerL
> ib.inf |  1 +
>  Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c                     | 11
> +++++++
>  Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.h                     |  5 +++
>  Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf                |  2 ++
>  10 files changed, 89 insertions(+), 2 deletions(-)
> 
> --
> 2.7.4.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel