From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E853D1A1E34 for ; Sun, 9 Oct 2016 19:14:17 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 09 Oct 2016 19:14:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,470,1473145200"; d="scan'208";a="178178206" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 09 Oct 2016 19:14:18 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 9 Oct 2016 19:14:17 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 9 Oct 2016 19:14:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.234]) with mapi id 14.03.0248.002; Mon, 10 Oct 2016 10:14:15 +0800 From: "Gao, Liming" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 0/4] Show test key info on front page Thread-Index: AQHSIiR+2W2YcdexA02o/jphUFa1dKCg8pCA Date: Mon, 10 Oct 2016 02:14:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B48270B@shsmsx102.ccr.corp.intel.com> References: <1476014313-11992-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1476014313-11992-1-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Show test key info on front page X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 02:14:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen: If the test key file is not built into BIOS image, BIOS code can't verify= the key is test key or not. I understand PcdTestKeyUsed high bit is design= ed for this case. But, I don't find UiApp logic to handle it.=20 Besides, could we find one common header to define BITS for PcdTestKeyUse= d? If so, you don't need to define them in every module.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jiewen Yao > Sent: Sunday, October 09, 2016 7:58 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/4] Show test key info on front page >=20 > This series patch supports to show the test key information > on the front page. > PcdTestKeyUsed is added to MdeModulePkg. >=20 > This PCD can be set by platform to indicate if there is any > test key used in current BIOS, such as recovery key, > or capsule update key. > Then the generic UI may consume this PCD to show warning information. >=20 > Jiewen Yao (4): > MdeModulePkg/dec: Add PcdTestKeyUsed PCD. > MdeModulePkg/UiApp: Show test key warning info in FrontPage. > QuarkPlatformPkg/Bds: Produce PcdTestKeyUsed. > Vlv2TbleDevicePkg/Bds: Produce PcdTestKeyUsed. >=20 > MdeModulePkg/Application/UiApp/FrontPageCustomizedUi.c = | > 34 ++++++++++++++++++++ > MdeModulePkg/Application/UiApp/FrontPageStrings.uni = | 8 > ++++- > MdeModulePkg/Application/UiApp/UiApp.inf = | 3 +- > MdeModulePkg/MdeModulePkg.dec = | 11 +++++++ >=20 > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager. > c | 11 +++++++ >=20 > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager. > h | 5 +++ >=20 > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerL > ib.inf | 1 + > Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c = | 11 > +++++++ > Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.h = | 5 +++ > Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf = | 2 ++ > 10 files changed, 89 insertions(+), 2 deletions(-) >=20 > -- > 2.7.4.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel