Re: [PATCH v3 1/5] MdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo HOB GUID and structure

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Monday, October 10, 2016 10:35 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v3 1/5] MdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo
> HOB GUID and structure
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Guid/GraphicsInfoHob.h | 17 ++++++++++++++++-
>  MdePkg/MdePkg.dec                     |  6 ++++++
>  2 files changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Guid/GraphicsInfoHob.h
> b/MdePkg/Include/Guid/GraphicsInfoHob.h
> index 3bcead0..b807213 100644
> --- a/MdePkg/Include/Guid/GraphicsInfoHob.h
> +++ b/MdePkg/Include/Guid/GraphicsInfoHob.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Hob guid for Information about the graphics mode.
> 
> -  Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution. The full text of the license may be
> found at
> @@ -25,12 +25,27 @@
>      0x39f62cce, 0x6825, 0x4669, { 0xbb, 0x56, 0x54, 0x1a, 0xba, 0x75, 0x3a,
> 0x07 } \
>    }
> 
> +#define EFI_PEI_GRAPHICS_DEVICE_INFO_HOB_GUID \
> +  { \
> +    0xe5cb2ac9, 0xd35d, 0x4430, { 0x93, 0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d,
> 0xe7 } \
> +  }
> +
>  typedef struct {
>    EFI_PHYSICAL_ADDRESS                  FrameBufferBase;
>    UINT32                                FrameBufferSize;
>    EFI_GRAPHICS_OUTPUT_MODE_INFORMATION  GraphicsMode;
>  } EFI_PEI_GRAPHICS_INFO_HOB;
> 
> +typedef struct {
> +  UINT16                                VendorId;           ///< Ignore if the value is 0xFFFF.
> +  UINT16                                DeviceId;           ///< Ignore if the value is 0xFFFF.
> +  UINT16                                SubsystemVendorId;  ///< Ignore if the value is
> 0xFFFF.
> +  UINT16                                SubsystemId;        ///< Ignore if the value is 0xFFFF.
> +  UINT8                                 RevisionId;         ///< Ignore if the value is 0xFF.
> +  UINT8                                 BarIndex;           ///< Ignore if the value is 0xFF.
> +} EFI_PEI_GRAPHICS_DEVICE_INFO_HOB;
> +
>  extern EFI_GUID gEfiGraphicsInfoHobGuid;
> +extern EFI_GUID gEfiGraphicsDeviceInfoHobGuid;
> 
>  #endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index 606e2f1..f1e5151 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -733,6 +733,12 @@ [Guids]
>    gEfiDiskInfoUfsInterfaceGuid   = { 0x4b3029cc, 0x6b98, 0x47fb, { 0xbc, 0x96,
> 0x76, 0xdc, 0xb8, 0x4, 0x41, 0xf0 }}
> 
>    #
> +  # GUID defined in PI1.5
> +  #
> +  ## Include/Guid/GraphicsInfoHob.h
> +  gEfiGraphicsDeviceInfoHobGuid     = { 0xe5cb2ac9, 0xd35d, 0x4430, { 0x93,
> 0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d, 0xe7 }}
> +
> +  #
>    # GUID defined in Windows UEFI Firmware Update Platform doc
>    #
>    ## Include/IndustryStandard/WindowsUxCapsule.h
> --
> 2.9.0.windows.1