public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Tim Lewis <tim.lewis@insyde.com>,
	edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: AsciiPrint behavior with \n linefeed characters.
Date: Fri, 14 Oct 2016 09:31:54 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4932A0@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <7236196A5DF6C040855A6D96F556A53F3F6968@msmail.insydesw.com.tw>

Tim:
  PrintLib only says \n in format string to be converted. It keeps other string as-is. So, this is the expected behavior. 

Thanks
Liming
> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Friday, October 14, 2016 10:05 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel-01 <edk2-
> devel@lists.01.org>
> Subject: RE: AsciiPrint behavior with \n linefeed characters.
> 
> Liming --
> 
> And I agree that this should be the behavior. I was surprised by the lack of
> translation for the other string printed via %s.
> 
> Tim
> 
> -----Original Message-----
> From: Gao, Liming [mailto:liming.gao@intel.com]
> Sent: Thursday, October 13, 2016 6:24 PM
> To: Tim Lewis <tim.lewis@insyde.com>; edk2-devel-01 <edk2-
> devel@lists.01.org>
> Subject: RE: AsciiPrint behavior with \n linefeed characters.
> 
> Tim:
>   The first parameter in AsciiPrint() is the Format string. Per PrintLib.h
> definition, \n will be changed to \r\n in the format string.
> 
> The following end of line(EOL) translations must be performed on the
> contents of the format string:
>      - '\\r' is translated to '\\r'
>      - '\\r\\n' is translated to '\\r\\n'
>      - '\\n' is translated to '\\r\\n'
>      - '\\n\\r' is translated to '\\r\\n'
> 
> Thanks
> Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Friday, October 14, 2016 5:29 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: [edk2] AsciiPrint behavior with \n linefeed characters.
> 
> In using AsciiPrint (I'm presuming the behavior is also in Print, but I haven't
> tested), I found an interesting behavior for linefeed characters embedded in
> strings that are parameters. I post it here just so people who are mystified by
> their output can understand it.
> 
> Consider this example:
> 
> CONST CHAR16 *XyzStr = "HI\nBYE";
> 
> AsciiPrint(XyzStr);
> AsciiPrint("Offset\n%s\n", XyzStr);
> 
> Output looks like this:
> 
> HI
> BYE
> Offset
> HI
>    BYE
> 
> It turns out that \n characters in the format string are converted to \r\n, but
> \n characters in strings that are embedded (as in the second example) are
> not converted. So only the linefeed character is interpreted, leading to "BYE"
> being suspended one character to the right and one row lower than "HI"
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2016-10-14  9:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 21:29 AsciiPrint behavior with \n linefeed characters Tim Lewis
2016-10-14  1:24 ` Gao, Liming
2016-10-14  2:05   ` Tim Lewis
2016-10-14  7:03     ` Joaquin Cono Bolillo
2016-10-14  9:31     ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4932A0@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox