From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 893321A1E3B for ; Mon, 17 Oct 2016 06:56:21 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 17 Oct 2016 06:56:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="20397988" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 17 Oct 2016 06:56:21 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 17 Oct 2016 06:56:20 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 17 Oct 2016 06:56:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002; Mon, 17 Oct 2016 21:56:18 +0800 From: "Gao, Liming" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [PATCH] MdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM Thread-Index: AQHSKGjDBsHc25mgIkSIRw2xO97nIKCsq3QA Date: Mon, 17 Oct 2016 13:56:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B495652@shsmsx102.ccr.corp.intel.com> References: <1476703343-14488-1-git-send-email-hao.a.wu@intel.com> In-Reply-To: <1476703343-14488-1-git-send-email-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGI5NTlkZDktM2ZlNy00NDM5LTk1NjctM2U3MjUxOTQyNmI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijl1OXoxUXdQcmd2b0FZWExuQjQreXFCNTlrUXhHXC9ZNm9maEh3cVlBZzZBPSJ9 x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 13:56:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao -----Original Message----- From: Wu, Hao A=20 Sent: Monday, October 17, 2016 7:22 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Kin= ney, Michael D Subject: [PATCH] MdePkg/BaseLib: Remove the unnecessary '_' before library = APIs in ASM/NASM The leading underscore (i.e. '_') before the names of some BaseLib library API in ASM/NASM files is unnecessary. It will cause link error with GCC tool chains. Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.asm | 6 +++--- MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.nasm | 6 +++--- MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.asm | 6 +++--- MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.nasm | 6 +++--- MdePkg/Library/BaseLib/Ia32/EnableInterrupts.asm | 6 +++--- MdePkg/Library/BaseLib/Ia32/EnableInterrupts.nasm | 6 +++--- MdePkg/Library/BaseLib/Ia32/Invd.asm | 6 +++--- MdePkg/Library/BaseLib/Ia32/Invd.nasm | 6 +++--- MdePkg/Library/BaseLib/Ia32/WriteLdtr.asm | 6 +++--- MdePkg/Library/BaseLib/Ia32/WriteLdtr.nasm | 6 +++--- 10 files changed, 30 insertions(+), 30 deletions(-) diff --git a/MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.asm b/MdePkg/Library= /BaseLib/Ia32/CpuBreakpoint.asm index e436405..ab7c2cf 100644 --- a/MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.asm +++ b/MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.asm @@ -1,5 +1,5 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -32,9 +32,9 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -_CpuBreakpoint PROC +CpuBreakpoint PROC int 3 ret -_CpuBreakpoint ENDP +CpuBreakpoint ENDP =20 END diff --git a/MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.nasm b/MdePkg/Librar= y/BaseLib/Ia32/CpuBreakpoint.nasm index fb1dd2e..b8ae0f9 100644 --- a/MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.nasm +++ b/MdePkg/Library/BaseLib/Ia32/CpuBreakpoint.nasm @@ -1,5 +1,5 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -29,8 +29,8 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -global ASM_PFX(_CpuBreakpoint) -ASM_PFX(_CpuBreakpoint): +global ASM_PFX(CpuBreakpoint) +ASM_PFX(CpuBreakpoint): int 3 ret =20 diff --git a/MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.asm b/MdeP= kg/Library/BaseLib/Ia32/EnableDisableInterrupts.asm index e54f14e..f108864 100644 --- a/MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.asm +++ b/MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.asm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -32,10 +32,10 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -_EnableDisableInterrupts PROC +EnableDisableInterrupts PROC sti cli ret -_EnableDisableInterrupts ENDP +EnableDisableInterrupts ENDP =20 END diff --git a/MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.nasm b/Mde= Pkg/Library/BaseLib/Ia32/EnableDisableInterrupts.nasm index 7b20675..f7a4f62 100644 --- a/MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.nasm +++ b/MdePkg/Library/BaseLib/Ia32/EnableDisableInterrupts.nasm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -30,8 +30,8 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -global ASM_PFX(_EnableDisableInterrupts) -ASM_PFX(_EnableDisableInterrupts): +global ASM_PFX(EnableDisableInterrupts) +ASM_PFX(EnableDisableInterrupts): sti cli ret diff --git a/MdePkg/Library/BaseLib/Ia32/EnableInterrupts.asm b/MdePkg/Libr= ary/BaseLib/Ia32/EnableInterrupts.asm index 58fc72d..b43d451 100644 --- a/MdePkg/Library/BaseLib/Ia32/EnableInterrupts.asm +++ b/MdePkg/Library/BaseLib/Ia32/EnableInterrupts.asm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -32,9 +32,9 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -_EnableInterrupts PROC +EnableInterrupts PROC sti ret -_EnableInterrupts ENDP +EnableInterrupts ENDP =20 END diff --git a/MdePkg/Library/BaseLib/Ia32/EnableInterrupts.nasm b/MdePkg/Lib= rary/BaseLib/Ia32/EnableInterrupts.nasm index 85ea692..ff8bbe45 100644 --- a/MdePkg/Library/BaseLib/Ia32/EnableInterrupts.nasm +++ b/MdePkg/Library/BaseLib/Ia32/EnableInterrupts.nasm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -30,8 +30,8 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -global ASM_PFX(_EnableInterrupts) -ASM_PFX(_EnableInterrupts): +global ASM_PFX(EnableInterrupts) +ASM_PFX(EnableInterrupts): sti ret =20 diff --git a/MdePkg/Library/BaseLib/Ia32/Invd.asm b/MdePkg/Library/BaseLib/= Ia32/Invd.asm index fadf3df..a34e217 100644 --- a/MdePkg/Library/BaseLib/Ia32/Invd.asm +++ b/MdePkg/Library/BaseLib/Ia32/Invd.asm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -32,9 +32,9 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -_AsmInvd PROC +AsmInvd PROC invd ret -_AsmInvd ENDP +AsmInvd ENDP =20 END diff --git a/MdePkg/Library/BaseLib/Ia32/Invd.nasm b/MdePkg/Library/BaseLib= /Ia32/Invd.nasm index 2d10cd8..c029eea 100644 --- a/MdePkg/Library/BaseLib/Ia32/Invd.nasm +++ b/MdePkg/Library/BaseLib/Ia32/Invd.nasm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -30,8 +30,8 @@ ; VOID ; ); ;-------------------------------------------------------------------------= ----- -global ASM_PFX(_AsmInvd) -ASM_PFX(_AsmInvd): +global ASM_PFX(AsmInvd) +ASM_PFX(AsmInvd): invd ret =20 diff --git a/MdePkg/Library/BaseLib/Ia32/WriteLdtr.asm b/MdePkg/Library/Bas= eLib/Ia32/WriteLdtr.asm index abcd74d..adec67d 100644 --- a/MdePkg/Library/BaseLib/Ia32/WriteLdtr.asm +++ b/MdePkg/Library/BaseLib/Ia32/WriteLdtr.asm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -32,10 +32,10 @@ ; IN UINT16 Ldtr ; ); ;-------------------------------------------------------------------------= ----- -_AsmWriteLdtr PROC +AsmWriteLdtr PROC mov eax, [esp + 4] lldt ax ret -_AsmWriteLdtr ENDP +AsmWriteLdtr ENDP =20 END diff --git a/MdePkg/Library/BaseLib/Ia32/WriteLdtr.nasm b/MdePkg/Library/Ba= seLib/Ia32/WriteLdtr.nasm index 40fbbad..692f1cc 100644 --- a/MdePkg/Library/BaseLib/Ia32/WriteLdtr.nasm +++ b/MdePkg/Library/BaseLib/Ia32/WriteLdtr.nasm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2006, Intel Corporation. All rights reserved.
+; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BS= D License ; which accompanies this distribution. The full text of the license may b= e found at @@ -30,8 +30,8 @@ ; IN UINT16 Ldtr ; ); ;-------------------------------------------------------------------------= ----- -global ASM_PFX(_AsmWriteLdtr) -ASM_PFX(_AsmWriteLdtr): +global ASM_PFX(AsmWriteLdtr) +ASM_PFX(AsmWriteLdtr): mov eax, [esp + 4] lldt ax ret --=20 1.9.5.msysgit.0