* [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
@ 2016-10-14 6:47 Liming Gao
2016-10-14 12:22 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Liming Gao @ 2016-10-14 6:47 UTC (permalink / raw)
To: edk2-devel
Remove extra qword in nasm code to make it pass build.
This file is only built in INTEL ICC compiler. So, there is missing
build check for it.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
.../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
index ee63ff7..206de40 100644
--- a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
+++ b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
@@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64):
mov edx, [esp + 20]
mov ebx, [esp + 24]
mov ecx, [esp + 28]
- lock cmpxchg8b qword [esi]
+ lock cmpxchg8b [esi]
pop ebx
pop esi
ret
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
2016-10-14 6:47 [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm Liming Gao
@ 2016-10-14 12:22 ` Laszlo Ersek
2016-10-18 1:36 ` Gao, Liming
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2016-10-14 12:22 UTC (permalink / raw)
To: Liming Gao, edk2-devel
On 10/14/16 08:47, Liming Gao wrote:
> Remove extra qword in nasm code to make it pass build.
> This file is only built in INTEL ICC compiler. So, there is missing
> build check for it.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
> .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> index ee63ff7..206de40 100644
> --- a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> +++ b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64):
> mov edx, [esp + 20]
> mov ebx, [esp + 24]
> mov ecx, [esp + 28]
> - lock cmpxchg8b qword [esi]
> + lock cmpxchg8b [esi]
> pop ebx
> pop esi
> ret
>
Suggested subject line:
MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC build
(73 characters)
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
2016-10-14 12:22 ` Laszlo Ersek
@ 2016-10-18 1:36 ` Gao, Liming
2016-10-18 1:47 ` Fan, Jeff
0 siblings, 1 reply; 4+ messages in thread
From: Gao, Liming @ 2016-10-18 1:36 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel@ml01.01.org
Thanks! I will use this subject.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, October 14, 2016 8:22 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@ml01.01.org
> Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update
> InterlockedCompareExchange64.nasm
>
> On 10/14/16 08:47, Liming Gao wrote:
> > Remove extra qword in nasm code to make it pass build.
> > This file is only built in INTEL ICC compiler. So, there is missing
> > build check for it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > ---
> > .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > index ee63ff7..206de40 100644
> > ---
> a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > +++
> b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64):
> > mov edx, [esp + 20]
> > mov ebx, [esp + 24]
> > mov ecx, [esp + 28]
> > - lock cmpxchg8b qword [esi]
> > + lock cmpxchg8b [esi]
> > pop ebx
> > pop esi
> > ret
> >
>
> Suggested subject line:
>
> MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC
> build
>
> (73 characters)
>
> Thanks,
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
2016-10-18 1:36 ` Gao, Liming
@ 2016-10-18 1:47 ` Fan, Jeff
0 siblings, 0 replies; 4+ messages in thread
From: Fan, Jeff @ 2016-10-18 1:47 UTC (permalink / raw)
To: Gao, Liming, Laszlo Ersek, edk2-devel@ml01.01.org
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming
Sent: Tuesday, October 18, 2016 9:36 AM
To: Laszlo Ersek; edk2-devel@ml01.01.org
Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
Thanks! I will use this subject.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, October 14, 2016 8:22 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@ml01.01.org
> Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update
> InterlockedCompareExchange64.nasm
>
> On 10/14/16 08:47, Liming Gao wrote:
> > Remove extra qword in nasm code to make it pass build.
> > This file is only built in INTEL ICC compiler. So, there is missing
> > build check for it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > ---
> > .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > index ee63ff7..206de40 100644
> > ---
> a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > +++
> b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64):
> > mov edx, [esp + 20]
> > mov ebx, [esp + 24]
> > mov ecx, [esp + 28]
> > - lock cmpxchg8b qword [esi]
> > + lock cmpxchg8b [esi]
> > pop ebx
> > pop esi
> > ret
> >
>
> Suggested subject line:
>
> MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC
> build
>
> (73 characters)
>
> Thanks,
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-18 1:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 6:47 [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm Liming Gao
2016-10-14 12:22 ` Laszlo Ersek
2016-10-18 1:36 ` Gao, Liming
2016-10-18 1:47 ` Fan, Jeff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox