From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B3B421A1DEF for ; Thu, 27 Oct 2016 20:01:11 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 27 Oct 2016 20:01:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,407,1473145200"; d="scan'208";a="894936277" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 27 Oct 2016 20:01:10 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 20:01:10 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 20:01:09 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Fri, 28 Oct 2016 11:01:06 +0800 From: "Gao, Liming" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes Thread-Index: AQHSMABc2IPeYthI0UWUWEemmFZNYKC9LuWw Date: Fri, 28 Oct 2016 03:01:05 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49B17A@shsmsx102.ccr.corp.intel.com> References: <1477538094-10676-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1477538094-10676-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 03:01:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Michael Kinney > Sent: Thursday, October 27, 2016 11:15 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h > includes >=20 > Based on Laszlo Ersek work to add ASSERT_RETURN_ERORR(): >=20 > https://lists.01.org/pipermail/edk2-devel/2016-October/003132.html >=20 > Laszlo also discovered libraries of type BASE that include > UefiBaseType.h that should not include that file: >=20 > https://lists.01.org/pipermail/edk2-devel/2016-October/003308.html >=20 > This change removes the extra #include of > from QNCSmmLib.c. >=20 > Cc: Kelly Steele > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney > --- > QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git > a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c > b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c > index 075d45f..5f2722a 100644 > --- a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c > +++ b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c > @@ -1,7 +1,7 @@ > /** @file > QNC Smm Library Services that implements SMM Region access, S/W SMI > generation and detection. >=20 > -Copyright (c) 2013-2015 Intel Corporation. > +Copyright (c) 2013-2016 Intel Corporation. >=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > @@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > #include > -#include > #include >=20 > #define BOOT_SERVICE_SOFTWARE_SMI_DATA 0 > -- > 2.6.3.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel