public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix a bug for tooldef class not include the newly Env
Date: Tue, 1 Nov 2016 01:29:12 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49C6C0@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1477629790-37220-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Friday, October 28, 2016 12:43 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix a bug for tooldef class not include the newly
> Env
> 
> Prebuild script may update os.environ, but the tooldef class not include
> the new ENV variables. so after the Launch prebuild script, we should
> re-init the tooldef class to include the new ENV variables.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/build/build.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/BaseTools/Source/Python/build/build.py
> b/BaseTools/Source/Python/build/build.py
> index f17b55c..35e7037 100644
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -823,10 +823,12 @@ class Build():
>              EdkLogger.quiet("%-16s = %s" % ("PREBUILD", self.PrebuildScript))
>          if self.PostbuildScript:
>              EdkLogger.quiet("%-16s = %s" % ("POSTBUILD", self.PostbuildScript))
>          if self.PrebuildScript:
>              self.LaunchPrebuild()
> +            self.TargetTxt = TargetTxtClassObject()
> +            self.ToolDef   = ToolDefClassObject()
>          if not (self.LaunchPrebuildFlag and
> os.path.exists(self.PlatformBuildPath)):
>              self.InitBuild()
> 
>          EdkLogger.info("")
>          os.chdir(self.WorkspaceDir)
> --
> 2.6.1.windows.1



      reply	other threads:[~2016-11-01  1:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  4:43 [Patch] BaseTools: Fix a bug for tooldef class not include the newly Env Yonghong Zhu
2016-11-01  1:29 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B49C6C0@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox