From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 259AF81D27 for ; Mon, 31 Oct 2016 18:29:15 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 31 Oct 2016 18:29:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,577,1473145200"; d="scan'208";a="896242838" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 31 Oct 2016 18:29:15 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 31 Oct 2016 18:29:15 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 31 Oct 2016 18:29:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Tue, 1 Nov 2016 09:29:12 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Fix a bug for tooldef class not include the newly Env Thread-Index: AQHSMNXPJkM8ijUQu0CY+QaPzszNJKDDXPHQ Date: Tue, 1 Nov 2016 01:29:12 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49C6C0@shsmsx102.ccr.corp.intel.com> References: <1477629790-37220-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1477629790-37220-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix a bug for tooldef class not include the newly Env X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2016 01:29:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zhu, Yonghong > Sent: Friday, October 28, 2016 12:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fix a bug for tooldef class not include the n= ewly > Env >=20 > Prebuild script may update os.environ, but the tooldef class not include > the new ENV variables. so after the Launch prebuild script, we should > re-init the tooldef class to include the new ENV variables. >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/build/build.py | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/BaseTools/Source/Python/build/build.py > b/BaseTools/Source/Python/build/build.py > index f17b55c..35e7037 100644 > --- a/BaseTools/Source/Python/build/build.py > +++ b/BaseTools/Source/Python/build/build.py > @@ -823,10 +823,12 @@ class Build(): > EdkLogger.quiet("%-16s =3D %s" % ("PREBUILD", self.PrebuildS= cript)) > if self.PostbuildScript: > EdkLogger.quiet("%-16s =3D %s" % ("POSTBUILD", self.Postbuil= dScript)) > if self.PrebuildScript: > self.LaunchPrebuild() > + self.TargetTxt =3D TargetTxtClassObject() > + self.ToolDef =3D ToolDefClassObject() > if not (self.LaunchPrebuildFlag and > os.path.exists(self.PlatformBuildPath)): > self.InitBuild() >=20 > EdkLogger.info("") > os.chdir(self.WorkspaceDir) > -- > 2.6.1.windows.1