* [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check
@ 2016-11-02 2:09 Song, BinX
2016-11-02 6:13 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Song, BinX @ 2016-11-02 2:09 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Gao, Liming
- '\0' -> NULL
- https://bugzilla.tianocore.org/show_bug.cgi?id=47
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c
index e48cbe8..4abe14f 100644
--- a/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c
+++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c
@@ -101,7 +101,7 @@ Returns:
return 0;
}
- if (ErrorString != '\0') {
+ if (ErrorString != NULL) {
if (gST->StdErr != NULL) {
//
// To be extra safe make sure StdErr has been initialized
--
2.7.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check
2016-11-02 2:09 [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check Song, BinX
@ 2016-11-02 6:13 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2016-11-02 6:13 UTC (permalink / raw)
To: Song, BinX, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: Song, BinX
Sent: Wednesday, November 2, 2016 10:09 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check
- '\0' -> NULL
- https://bugzilla.tianocore.org/show_bug.cgi?id=47
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c
index e48cbe8..4abe14f 100644
--- a/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c
+++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c
@@ -101,7 +101,7 @@ Returns:
return 0;
}
- if (ErrorString != '\0') {
+ if (ErrorString != NULL) {
if (gST->StdErr != NULL) {
//
// To be extra safe make sure StdErr has been initialized
--
2.7.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-02 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-02 2:09 [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check Song, BinX
2016-11-02 6:13 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox