From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 44EDB81CE1 for ; Tue, 1 Nov 2016 23:13:04 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 01 Nov 2016 23:13:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="1079354942" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 01 Nov 2016 23:13:06 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Nov 2016 23:13:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0248.002; Wed, 2 Nov 2016 14:13:03 +0800 From: "Gao, Liming" To: "Song, BinX" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check Thread-Index: AdI0riLw767HFqRdQ6WxbzoRY20nIwAIgTNQ Date: Wed, 2 Nov 2016 06:13:02 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49D671@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF135486C@shsmsx102.ccr.corp.intel.com> In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF135486C@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQ0ZmY1ODYtZGVlNy00NTQ4LTlhNTYtOGYyMTJiZjYwYjUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ild3cEZEaGp5a2tDTnV1NkhPXC9HSEhUXC9vRE5GSGZCbzZZUjNuNm5yMmk3QT0ifQ== x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 06:13:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao -----Original Message----- From: Song, BinX=20 Sent: Wednesday, November 2, 2016 10:09 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL= char check - '\0' -> NULL - https://bugzilla.tianocore.org/show_bug.cgi?id=3D47 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c = b/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c index e48cbe8..4abe14f 100644 --- a/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c +++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c @@ -101,7 +101,7 @@ Returns: return 0; } =20 - if (ErrorString !=3D '\0') { + if (ErrorString !=3D NULL) { if (gST->StdErr !=3D NULL) { // // To be extra safe make sure StdErr has been initialized --=20 2.7.2.windows.1