From: "Gao, Liming" <liming.gao@intel.com>
To: "Song, BinX" <binx.song@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
Date: Wed, 2 Nov 2016 08:44:02 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49D8FA@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF1354922@shsmsx102.ccr.corp.intel.com>
Bin:
I suggest move CHAR_NULL definition from Protocol\SimpleTextIn.h to Base.h
Thanks
Liming
-----Original Message-----
From: Song, BinX
Sent: Wednesday, November 2, 2016 4:27 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
- https://bugzilla.tianocore.org/show_bug.cgi?id=172
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
MdePkg/Include/Base.h | 7 +++++++
MdePkg/Library/BaseLib/FilePaths.c | 2 --
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 2217058..0c3318f 100644
--- a/MdePkg/Include/Base.h
+++ b/MdePkg/Include/Base.h
@@ -338,6 +338,13 @@ struct _LIST_ENTRY {
///
#define NULL ((VOID *) 0)
+//
+// Required unicode control chars
+//
+#ifndef CHAR_NULL
+#define CHAR_NULL 0x0000
+#endif
+
///
/// Maximum values for common UEFI Data Types
///
diff --git a/MdePkg/Library/BaseLib/FilePaths.c b/MdePkg/Library/BaseLib/FilePaths.c
index c8da6bb..183b323 100644
--- a/MdePkg/Library/BaseLib/FilePaths.c
+++ b/MdePkg/Library/BaseLib/FilePaths.c
@@ -10,10 +10,8 @@
THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
-#include <Uefi/UefiBaseType.h>
#include <Library/BaseMemoryLib.h>
#include <Library/BaseLib.h>
-#include <Protocol/SimpleTextIn.h>
/**
Removes the last directory or file entry in a path by changing the last
--
2.7.2.windows.1
next prev parent reply other threads:[~2016-11-02 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 8:27 [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib Song, BinX
2016-11-02 8:44 ` Gao, Liming [this message]
2016-11-02 16:47 ` Kinney, Michael D
2016-11-03 1:08 ` Song, BinX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B49D8FA@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox