Re: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib

["Gao, Liming" <liming.gao@intel.com>]

Bin:
  On CHAR_NULL definition in Base.h, its comment should be Null character. And, for the second version patch, you need change title to PATCH V2, and describe what changes in V2. 

> +//
> +// Required unicode control chars  ==> Null character
> +//
> +#define CHAR_NULL             0x0000

Thanks
Liming
> -----Original Message-----
> From: Song, BinX
> Sent: Thursday, November 03, 2016 9:31 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in
> BaseLib
> 
> - https://bugzilla.tianocore.org/show_bug.cgi?id=172
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
>  MdePkg/Include/Base.h                  | 5 +++++
>  MdePkg/Include/Protocol/SimpleTextIn.h | 1 -
>  MdePkg/Library/BaseLib/FilePaths.c     | 2 --
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index 2217058..2441875 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -338,6 +338,11 @@ struct _LIST_ENTRY {
>  ///
>  #define NULL  ((VOID *) 0)
> 
> +//
> +// Required unicode control chars
> +//
> +#define CHAR_NULL             0x0000
> +
>  ///
>  /// Maximum values for common UEFI Data Types
>  ///
> diff --git a/MdePkg/Include/Protocol/SimpleTextIn.h
> b/MdePkg/Include/Protocol/SimpleTextIn.h
> index 71dcb0b..ebe1c7e 100644
> --- a/MdePkg/Include/Protocol/SimpleTextIn.h
> +++ b/MdePkg/Include/Protocol/SimpleTextIn.h
> @@ -46,7 +46,6 @@ typedef struct {
>  //
>  // Required unicode control chars
>  //
> -#define CHAR_NULL             0x0000
>  #define CHAR_BACKSPACE        0x0008
>  #define CHAR_TAB              0x0009
>  #define CHAR_LINEFEED         0x000A
> diff --git a/MdePkg/Library/BaseLib/FilePaths.c
> b/MdePkg/Library/BaseLib/FilePaths.c
> index c8da6bb..183b323 100644
> --- a/MdePkg/Library/BaseLib/FilePaths.c
> +++ b/MdePkg/Library/BaseLib/FilePaths.c
> @@ -10,10 +10,8 @@
>    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
>    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
>  **/
> -#include  <Uefi/UefiBaseType.h>
>  #include  <Library/BaseMemoryLib.h>
>  #include  <Library/BaseLib.h>
> -#include  <Protocol/SimpleTextIn.h>
> 
>  /**
>    Removes the last directory or file entry in a path by changing the last
> --
> 2.7.2.windows.1