From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BAB2F81CC9 for ; Wed, 2 Nov 2016 18:56:02 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 02 Nov 2016 18:56:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,436,1473145200"; d="scan'208";a="1063170798" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 02 Nov 2016 18:56:05 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 18:56:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 18:56:03 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Thu, 3 Nov 2016 09:56:01 +0800 From: "Gao, Liming" To: "Song, BinX" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib Thread-Index: AdI1cfJrDdsxHpRYQsK8+mqvX7VDTwAAskdA Date: Thu, 3 Nov 2016 01:56:01 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49DF7D@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF1354B23@shsmsx102.ccr.corp.intel.com> In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF1354B23@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 01:56:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bin: On CHAR_NULL definition in Base.h, its comment should be Null character. = And, for the second version patch, you need change title to PATCH V2, and d= escribe what changes in V2.=20 > +// > +// Required unicode control chars =3D=3D> Null character > +// > +#define CHAR_NULL 0x0000 Thanks Liming > -----Original Message----- > From: Song, BinX > Sent: Thursday, November 03, 2016 9:31 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in > BaseLib >=20 > - https://bugzilla.tianocore.org/show_bug.cgi?id=3D172 >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Bell Song > --- > MdePkg/Include/Base.h | 5 +++++ > MdePkg/Include/Protocol/SimpleTextIn.h | 1 - > MdePkg/Library/BaseLib/FilePaths.c | 2 -- > 3 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index 2217058..2441875 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -338,6 +338,11 @@ struct _LIST_ENTRY { > /// > #define NULL ((VOID *) 0) >=20 > +// > +// Required unicode control chars > +// > +#define CHAR_NULL 0x0000 > + > /// > /// Maximum values for common UEFI Data Types > /// > diff --git a/MdePkg/Include/Protocol/SimpleTextIn.h > b/MdePkg/Include/Protocol/SimpleTextIn.h > index 71dcb0b..ebe1c7e 100644 > --- a/MdePkg/Include/Protocol/SimpleTextIn.h > +++ b/MdePkg/Include/Protocol/SimpleTextIn.h > @@ -46,7 +46,6 @@ typedef struct { > // > // Required unicode control chars > // > -#define CHAR_NULL 0x0000 > #define CHAR_BACKSPACE 0x0008 > #define CHAR_TAB 0x0009 > #define CHAR_LINEFEED 0x000A > diff --git a/MdePkg/Library/BaseLib/FilePaths.c > b/MdePkg/Library/BaseLib/FilePaths.c > index c8da6bb..183b323 100644 > --- a/MdePkg/Library/BaseLib/FilePaths.c > +++ b/MdePkg/Library/BaseLib/FilePaths.c > @@ -10,10 +10,8 @@ > THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > **/ > -#include > #include > #include > -#include >=20 > /** > Removes the last directory or file entry in a path by changing the las= t > -- > 2.7.2.windows.1