public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug to support generate FFS by Align = Auto
Date: Fri, 4 Nov 2016 02:10:10 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49E934@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1478181496-24348-1-git-send-email-yonghong.zhu@intel.com>

Yonghong:
  If Align is Auto, it means FFS alignment will inherit the alignment from its child section. Right?
  If Align is not specifies, it also means FFS alignment will inherit the alignment from its child section.

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, November 03, 2016 9:58 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fix the bug to support generate FFS by
> Align = Auto
> 
> FDF spec support to use 'Auto' as <FfsAlignmentValues>, but current Tool
> report error about -a=Auto is invalid option.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> index c3f3624..05c4070 100644
> --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> @@ -432,10 +432,12 @@ class GenFdsGlobalVariable:
>          if Fixed == True:
>              Cmd += ["-x"]
>          if CheckSum:
>              Cmd += ["-s"]
>          if Align not in [None, '']:
> +            if Align == 'Auto':
> +                Align = '1'
>              Cmd += ["-a", Align]
> 
>          Cmd += ["-o", Output]
>          for I in range(0, len(Input)):
>              Cmd += ("-i", Input[I])
> --
> 2.6.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-11-04  2:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 13:58 [Patch] BaseTools: Fix the bug to support generate FFS by Align = Auto Yonghong Zhu
2016-11-04  2:10 ` Gao, Liming [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-11-09 10:34 [Patch] BaseTools: Fix the bug to support generate FFS by Align=Auto Yonghong Zhu
2016-11-14  8:38 ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B49E934@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox