From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72EDD81D65 for ; Thu, 3 Nov 2016 19:10:12 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 03 Nov 2016 19:10:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,589,1473145200"; d="scan'208";a="187443607" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 03 Nov 2016 19:10:14 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Nov 2016 19:10:14 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Nov 2016 19:10:13 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002; Fri, 4 Nov 2016 10:10:11 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Fix the bug to support generate FFS by Align = Auto Thread-Index: AQHSNdppOaqiu7UhJkOTaaifCAegn6DIFNEQ Date: Fri, 4 Nov 2016 02:10:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49E934@shsmsx102.ccr.corp.intel.com> References: <1478181496-24348-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1478181496-24348-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the bug to support generate FFS by Align = Auto X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 02:10:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yonghong: If Align is Auto, it means FFS alignment will inherit the alignment from = its child section. Right? If Align is not specifies, it also means FFS alignment will inherit the a= lignment from its child section. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, November 03, 2016 9:58 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Fix the bug to support generate FFS by > Align =3D Auto >=20 > FDF spec support to use 'Auto' as , but current Tool > report error about -a=3DAuto is invalid option. >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > index c3f3624..05c4070 100644 > --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > @@ -432,10 +432,12 @@ class GenFdsGlobalVariable: > if Fixed =3D=3D True: > Cmd +=3D ["-x"] > if CheckSum: > Cmd +=3D ["-s"] > if Align not in [None, '']: > + if Align =3D=3D 'Auto': > + Align =3D '1' > Cmd +=3D ["-a", Align] >=20 > Cmd +=3D ["-o", Output] > for I in range(0, len(Input)): > Cmd +=3D ("-i", Input[I]) > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel