From: "Gao, Liming" <liming.gao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH v2 00/53] Resolve issues for C source codes in BaseTools
Date: Tue, 8 Nov 2016 01:05:55 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4A05FD@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1478157783-9368-1-git-send-email-hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: Wu, Hao A
Sent: Thursday, November 3, 2016 3:22 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH v2 00/53] Resolve issues for C source codes in BaseTools
Compared with V1, the following changes are made:
1. More detailed log for commits that resolve the format mismatch in scanf
functions
2. Add definitions for format strings that will be used to construct the
commands to be executed via system() API
3. Use allocated buffers (instead of fixed-size arrays) to store file/
directory names across VfrCompile tool codes
The patch series is also available at:
https://github.com/hwu25/edk2/tree/BaseTools_V2
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Hao Wu (53):
BaseTools/C/Common: Avoid possible NULL pointer dereference
BaseTools/EfiRom: Avoid possible NULL pointer dereference
BaseTools/GenFfs: Avoid possible NULL pointer dereference
BaseTools/GenFv: Avoid possible NULL pointer dereference
BaseTools/GenFw: Avoid possible NULL pointer dereference
BaseTools/GenPage: Avoid possible NULL pointer dereference
BaseTools/GenSec: Avoid possible NULL pointer dereference
BaseTools/GenVtf: Avoid possible NULL pointer dereference
BaseTools/TianoCompress: Avoid possible NULL pointer dereference
BaseTools/VfrCompile: Avoid possible NULL pointer dereference
BaseTools/VolInfo: Avoid possible NULL pointer dereference
BaseTools/TianoCompress: Initialize local variables before being used
BaseTools/VfrCompile: Initialize local variables before being used
BaseTools/GenBootSector: Fix parameter format mismatch in printf
functions
BaseTools/VolInfo: Fix parameter format mismatch in printf functions
BaseTools/C/Common: Fix parameter format mismatch in scanf functions
BaseTools/GenFv: Fix parameter format mismatch in scanf functions
BaseTools/GenFw: Fix parameter format mismatch in scanf functions
BaseTools/GenVtf: Fix parameter format mismatch in scanf functions
BaseTools/C/Common: Add checks for array access
BaseTools/TianoCompress: Add checks for array access
BaseTools/VfrCompile: Add checks for array access
BaseTools/EfiRom: Add checks for user/file inputs
BaseTools/GenFv: Add checks for user/file inputs
BaseTools/VfrCompile: Add checks for user/file inputs
BaseTools/VfrCompile: Avoid freeing memory with mismatched functions
BaseTools/VfrCompile: Add assignment operator definition for some
classes
BaseTools/VfrCompile: Avoid freeing freed memory in classes
BaseTools/VfrCompile: Remove unused local variables
BaseTools/C/Common: Fix potential memory leak
BaseTools/EfiRom: Fix potential memory leak
BaseTools/GenFv: Fix potential memory leak
BaseTools/GenPage: Fix potential memory leak
BaseTools/GenSec: Fix potential memory leak
BaseTools/GenVtf: Fix potential memory leak
BaseTools/Split: Fix potential memory and resource leak
BaseTools/TianoCompress: Fix potential memory leak
BaseTools/VfrCompile: Fix potential memory leak
BaseTools/VolInfo: Fix potential memory leak
BaseTools/EfiRom: Fix file handles not being closed
BaseTools/GenBootSector: Fix file handles not being closed
BaseTools/GenCrc32: Fix file handles not being closed
BaseTools/GenFv: Fix file handles not being closed
BaseTools/GenVtf: Fix file handles not being closed
BaseTools/LzmaCompress: Fix file handles not being closed
BaseTools/TianoCompress: Fix file handles not being closed
BaseTools/VolInfo: Fix file handles not being closed
BaseTools/GenVtf: Provide string width in '%s' specifier in format
string
BaseTools/VolInfo: Provide string width in '%s' specifier in format
string
BaseTools/VfrCompile: Explicitly state format string for DebugMsg()
BaseTools/VolInfo: Add definitions for command format strings
BaseTools/VfrCompile/Pccts: Add virtual destructor for class
DLGInputStream
BaseTools/VfrCompile/Pccts: Make assignment operator not returning
void
BaseTools/Source/C/Common/BasePeCoff.c | 12 ++
BaseTools/Source/C/Common/CommonLib.c | 8 +-
BaseTools/Source/C/Common/Decompress.c | 41 ++--
BaseTools/Source/C/Common/EfiUtilityMsgs.c | 20 +-
BaseTools/Source/C/Common/FirmwareVolumeBuffer.c | 6 +-
BaseTools/Source/C/Common/MemoryFile.c | 3 +-
BaseTools/Source/C/Common/MyAlloc.c | 55 +++++-
.../Source/C/Common/ParseGuidedSectionTools.c | 21 ++-
BaseTools/Source/C/Common/ParseInf.c | 10 +-
BaseTools/Source/C/Common/SimpleFileParsing.c | 6 +-
BaseTools/Source/C/Common/TianoCompress.c | 9 +-
BaseTools/Source/C/EfiRom/EfiRom.c | 120 ++++++++----
BaseTools/Source/C/GenBootSector/GenBootSector.c | 43 +++--
BaseTools/Source/C/GenCrc32/GenCrc32.c | 3 +-
BaseTools/Source/C/GenFfs/GenFfs.c | 36 ++--
BaseTools/Source/C/GenFv/GenFv.c | 9 +-
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 79 +++++++-
BaseTools/Source/C/GenFw/Elf32Convert.c | 8 +
BaseTools/Source/C/GenFw/Elf64Convert.c | 10 +-
BaseTools/Source/C/GenFw/ElfConvert.c | 7 +-
BaseTools/Source/C/GenFw/GenFw.c | 20 +-
BaseTools/Source/C/GenPage/GenPage.c | 12 +-
BaseTools/Source/C/GenSec/GenSec.c | 27 ++-
BaseTools/Source/C/GenVtf/GenVtf.c | 113 ++++++++++-
BaseTools/Source/C/LzmaCompress/LzmaCompress.c | 4 +-
BaseTools/Source/C/Split/Split.c | 41 ++--
BaseTools/Source/C/TianoCompress/TianoCompress.c | 68 ++++---
BaseTools/Source/C/VfrCompile/Pccts/h/ATokPtr.h | 4 +-
.../Source/C/VfrCompile/Pccts/h/ATokPtrImpl.h | 6 +-
BaseTools/Source/C/VfrCompile/Pccts/h/DLexer.h | 3 +
BaseTools/Source/C/VfrCompile/Pccts/h/DLexerBase.h | 4 +
BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 207 ++++++++++++++++++---
BaseTools/Source/C/VfrCompile/VfrCompiler.h | 14 +-
BaseTools/Source/C/VfrCompile/VfrError.cpp | 4 +-
BaseTools/Source/C/VfrCompile/VfrError.h | 10 +-
BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 29 ++-
BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 13 ++
BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 54 ++++--
BaseTools/Source/C/VfrCompile/VfrUtilityLib.h | 60 +++++-
BaseTools/Source/C/VolInfo/VolInfo.c | 107 +++++++++--
BaseTools/Source/C/VolInfo/VolInfo.h | 5 +-
41 files changed, 1053 insertions(+), 258 deletions(-)
--
1.9.5.msysgit.0
prev parent reply other threads:[~2016-11-08 1:05 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 7:22 [PATCH v2 00/53] Resolve issues for C source codes in BaseTools Hao Wu
2016-11-03 7:22 ` [PATCH v2 01/53] BaseTools/C/Common: Avoid possible NULL pointer dereference Hao Wu
2016-11-03 7:22 ` [PATCH v2 02/53] BaseTools/EfiRom: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 03/53] BaseTools/GenFfs: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 04/53] BaseTools/GenFv: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 05/53] BaseTools/GenFw: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 06/53] BaseTools/GenPage: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 07/53] BaseTools/GenSec: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 08/53] BaseTools/GenVtf: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 09/53] BaseTools/TianoCompress: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 10/53] BaseTools/VfrCompile: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 11/53] BaseTools/VolInfo: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 12/53] BaseTools/TianoCompress: Initialize local variables before being used Hao Wu
2016-11-03 7:22 ` [PATCH v2 13/53] BaseTools/VfrCompile: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 14/53] BaseTools/GenBootSector: Fix parameter format mismatch in printf functions Hao Wu
2016-11-03 7:22 ` [PATCH v2 15/53] BaseTools/VolInfo: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 16/53] BaseTools/C/Common: Fix parameter format mismatch in scanf functions Hao Wu
2016-11-03 7:22 ` [PATCH v2 17/53] BaseTools/GenFv: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 18/53] BaseTools/GenFw: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 19/53] BaseTools/GenVtf: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 20/53] BaseTools/C/Common: Add checks for array access Hao Wu
2016-11-03 7:22 ` [PATCH v2 21/53] BaseTools/TianoCompress: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 22/53] BaseTools/VfrCompile: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 23/53] BaseTools/EfiRom: Add checks for user/file inputs Hao Wu
2016-11-03 7:22 ` [PATCH v2 24/53] BaseTools/GenFv: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 25/53] BaseTools/VfrCompile: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 26/53] BaseTools/VfrCompile: Avoid freeing memory with mismatched functions Hao Wu
2016-11-03 7:22 ` [PATCH v2 27/53] BaseTools/VfrCompile: Add assignment operator definition for some classes Hao Wu
2016-11-03 7:22 ` [PATCH v2 28/53] BaseTools/VfrCompile: Avoid freeing freed memory in classes Hao Wu
2016-11-03 7:22 ` [PATCH v2 29/53] BaseTools/VfrCompile: Remove unused local variables Hao Wu
2016-11-03 7:22 ` [PATCH v2 30/53] BaseTools/C/Common: Fix potential memory leak Hao Wu
2016-11-03 7:22 ` [PATCH v2 31/53] BaseTools/EfiRom: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 32/53] BaseTools/GenFv: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 33/53] BaseTools/GenPage: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 34/53] BaseTools/GenSec: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 35/53] BaseTools/GenVtf: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 36/53] BaseTools/Split: Fix potential memory and resource leak Hao Wu
2016-11-03 7:22 ` [PATCH v2 37/53] BaseTools/TianoCompress: Fix potential memory leak Hao Wu
2016-11-03 7:22 ` [PATCH v2 38/53] BaseTools/VfrCompile: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 39/53] BaseTools/VolInfo: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 40/53] BaseTools/EfiRom: Fix file handles not being closed Hao Wu
2016-11-03 7:22 ` [PATCH v2 41/53] BaseTools/GenBootSector: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 42/53] BaseTools/GenCrc32: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 43/53] BaseTools/GenFv: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 44/53] BaseTools/GenVtf: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 45/53] BaseTools/LzmaCompress: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 46/53] BaseTools/TianoCompress: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 47/53] BaseTools/VolInfo: " Hao Wu
2016-11-03 7:22 ` [PATCH v2 48/53] BaseTools/GenVtf: Provide string width in '%s' specifier in format string Hao Wu
2016-11-03 7:22 ` [PATCH v2 49/53] BaseTools/VolInfo: " Hao Wu
2016-11-03 7:23 ` [PATCH v2 50/53] BaseTools/VfrCompile: Explicitly state format string for DebugMsg() Hao Wu
2016-11-03 7:23 ` [PATCH v2 51/53] BaseTools/VolInfo: Add definitions for command format strings Hao Wu
2016-11-03 7:23 ` [PATCH v2 52/53] BaseTools/VfrCompile/Pccts: Add virtual destructor for class DLGInputStream Hao Wu
2016-11-03 7:23 ` [PATCH v2 53/53] BaseTools/VfrCompile/Pccts: Make assignment operator not returning void Hao Wu
2016-11-08 1:05 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4A05FD@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox