From: "Gao, Liming" <liming.gao@intel.com>
To: "Song, BinX" <binx.song@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
Date: Wed, 9 Nov 2016 02:24:56 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4A0C1D@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF135530D@shsmsx102.ccr.corp.intel.com>
Bin:
Why remove FreePool (Blt)? It is still used.
Thanks
Liming
> -----Original Message-----
> From: Song, BinX
> Sent: Tuesday, November 08, 2016 11:01 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
>
> There are two invalid if judgments in BootLogoEnableLogo() function,
> remove them.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 2c1e8ea..b69dda8 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -141,14 +141,6 @@ BootLogoEnableLogo (
> if (EFI_ERROR (Status)) {
> break;
> }
> -
> - if (EFI_ERROR (Status)) {
> - continue;
> - }
> -
> - if (Blt != NULL) {
> - FreePool (Blt);
> - }
> Blt = Image.Bitmap;
>
> //
> --
> 2.7.2.windows.1
next prev parent reply other threads:[~2016-11-09 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 3:01 [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments Song, BinX
2016-11-09 2:24 ` Gao, Liming [this message]
2016-11-10 5:42 ` Song, BinX
2016-11-10 7:54 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4A0C1D@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox