From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liming.gao@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 5B7AE81D1C
 for <edk2-devel@lists.01.org>; Tue,  8 Nov 2016 18:24:56 -0800 (PST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 08 Nov 2016 18:24:59 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,612,1473145200"; d="scan'208";a="1057141707"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga001.jf.intel.com with ESMTP; 08 Nov 2016 18:24:59 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 8 Nov 2016 18:24:59 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0248.002;
 Wed, 9 Nov 2016 10:24:57 +0800
From: "Gao, Liming" <liming.gao@intel.com>
To: "Song, BinX" <binx.song@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Thread-Topic: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
Thread-Index: AdI5bGYtKg7YBQKaTfa0QQ59IHzODwAw/F1w
Date: Wed, 9 Nov 2016 02:24:56 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4A0C1D@shsmsx102.ccr.corp.intel.com>
References: <559D2DF22BC9A3468B4FA1AA547F0EF135530D@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF135530D@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Nov 2016 02:24:56 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Bin:
  Why remove FreePool (Blt)? It is still used. =20

Thanks
Liming
> -----Original Message-----
> From: Song, BinX
> Sent: Tuesday, November 08, 2016 11:01 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
>=20
> There are two invalid if judgments in BootLogoEnableLogo() function,
> remove them.
>=20
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
>  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 --------
>  1 file changed, 8 deletions(-)
>=20
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 2c1e8ea..b69dda8 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -141,14 +141,6 @@ BootLogoEnableLogo (
>      if (EFI_ERROR (Status)) {
>        break;
>      }
> -
> -    if (EFI_ERROR (Status)) {
> -      continue;
> -    }
> -
> -    if (Blt !=3D NULL) {
> -      FreePool (Blt);
> -    }
>      Blt =3D Image.Bitmap;
>=20
>      //
> --
> 2.7.2.windows.1