From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liming.gao@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 6E0DE81C87
 for <edk2-devel@lists.01.org>; Thu, 10 Nov 2016 00:31:31 -0800 (PST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga102.jf.intel.com with ESMTP; 10 Nov 2016 00:31:34 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,618,1473145200"; d="scan'208";a="29593987"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by fmsmga006.fm.intel.com with ESMTP; 10 Nov 2016 00:31:34 -0800
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 10 Nov 2016 00:31:34 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 10 Nov 2016 00:31:33 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002;
 Thu, 10 Nov 2016 16:31:30 +0800
From: "Gao, Liming" <liming.gao@intel.com>
To: "Song, BinX" <binx.song@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
Thread-Topic: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments
Thread-Index: AdI7Kzk4CIswApsNTpykG/5YbSwszwAAZUig
Date: Thu, 10 Nov 2016 08:31:30 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B05D1@shsmsx102.ccr.corp.intel.com>
References: <559D2DF22BC9A3468B4FA1AA547F0EF1359DB6@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF1359DB6@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Nov 2016 08:31:31 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Song, BinX
> Sent: Thursday, November 10, 2016 4:20 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
>=20
> FreePool (Blt) function will be called in while loop, cannot be removed.
>=20
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
>  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 2c1e8ea..8bd9985 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -142,10 +142,6 @@ BootLogoEnableLogo (
>        break;
>      }
>=20
> -    if (EFI_ERROR (Status)) {
> -      continue;
> -    }
> -
>      if (Blt !=3D NULL) {
>        FreePool (Blt);
>      }
> --
> 2.10.2.windows.1