From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 287C181E89 for ; Fri, 11 Nov 2016 05:57:37 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 11 Nov 2016 05:57:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,621,1473145200"; d="scan'208,217";a="190332234" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 11 Nov 2016 05:57:40 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Nov 2016 05:57:40 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Nov 2016 05:57:39 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Fri, 11 Nov 2016 21:57:36 +0800 From: "Gao, Liming" To: Evan Lloyd , Laszlo Ersek , "edk2-devel (edk2-devel@lists.01.org)" CC: Leif Lindholm Thread-Topic: [edk2] File mode problem on Github edk2-BaseTools-win32 Thread-Index: AQHSPA4ty0e7S0kEB0608FxcJUpBGaDTPE6AgACRdxA= Date: Fri, 11 Nov 2016 13:57:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B0FE6@shsmsx102.ccr.corp.intel.com> References: <8f47b193-8855-8a0c-5e97-9eb9373d6d66@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWZhMTdiNTUtNzg0MC00YmFmLWFkYTgtZWIyNDUzZGY0NjY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjIyUGlSRUZTYUZqZWJ2TkJGYUsyeG44RTZxSDZTbTFhNSszQlhFYTNseXc9In0= x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: File mode problem on Github edk2-BaseTools-win32 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 13:57:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Evan: Yes. I expect you send the patch into this mail list. After I review and = test, I will help push it into edk2-BaseTools-win32 repo. As you mention, t= his repo is still the mirror of svn. Any change in this repo will impact th= e mirror sync. So, we expect the patch to be applied. Thanks Liming From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Evan= Lloyd Sent: Friday, November 11, 2016 9:13 PM To: Laszlo Ersek ; edk2-devel (edk2-devel@lists.01.org) = Cc: Gao, Liming ; Leif Lindholm Subject: Re: [edk2] File mode problem on Github edk2-BaseTools-win32 Hi Laszlo. >-----Original Message----- >From: Laszlo Ersek [mailto:lersek@redhat.com] >Sent: 11 November 2016 11:24 >To: Evan Lloyd; edk2-devel (edk2-devel@lists.01.org) >Cc: Leif Lindholm; liming.gao@intel.com >Subject: Re: [edk2] File mode problem on Github edk2-BaseTools-win32 ... >> Liming, >> Because this is purely a permission problem in the Git repository, and .= exe >files are not amenable to patching, > >They are -- I think if you change the file mode bits, git will see that, a= nd will >create a patch that has no content hunks, just the file mode changes. A semantic quibble; ".exe files are not amenable to patching" is true, the = file ATTRIBUTES may be. Patches against a .exe (or .dll) should surely start alarm bells ringing fo= r most people. > >For example, in the BaseTools/Conf/ directory, we happen have two >template files that have gratuitous execute permissions. If I remove those >permissions, "git diff" shows > ... >(The above patch is one I could submit genuinely, but I'm too lazy. :)) And somebody on the list would only object, so why bother? ;-) > >> I have raised a pull request on https://github.com/tianocore/edk2- >BaseTools-win32/pulls >> This is only a minor thing, but I would deem it a great favour were you = to >accept the pull request. >> It has me tearing my hair out, and I have little enough to begin with. := -{ > >It is fine to send pull requests, but: >- they should be mailed to the list (not opened on github), >- the patches have to be reviewed first, anyway. > >(Speaking about the edk2 repo at least -- I realize this is a different re= po.) As you point out, this is for a different repo; provided (I think) as a con= venience, and is ancillary to edk2. My viewpoint is that this is a specialised aspect, of interest to very few = people. (Does anyone else use Cygwin Git and the Win32 binaries?) The only reason for publishing this request here was one of awareness. Most= people will, I expect, be blissfully unconcerned. I am happy to submit a patch though, should those responsible (Liming?) wan= t that. Until that is confirmed though, I'm assuming that the GitHub repo is a mirr= or of a Subversion original (which will not record modes), so applying a pa= tch might involve a lot more work than accepting the pull request on GitHub= . Regards, Evan > >Thanks >Laszlo IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel