From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug to support generate FFS by Align=Auto
Date: Mon, 14 Nov 2016 08:38:41 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B188F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1478687699-31688-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Wednesday, November 09, 2016 6:35 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix the bug to support generate FFS by
> Align=Auto
>
> FDF spec support to use 'Auto' as <FfsAlignmentValues>, but current Tool
> report error about -a=Auto is invalid option when we set Align=Auto for
> RAW File.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/GenFds/FdfParser.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
> b/BaseTools/Source/Python/GenFds/FdfParser.py
> index 5489df5..f17a41f 100644
> --- a/BaseTools/Source/Python/GenFds/FdfParser.py
> +++ b/BaseTools/Source/Python/GenFds/FdfParser.py
> @@ -2744,11 +2744,13 @@ class FdfParser:
> while True:
> AlignValue = None
> if self.__GetAlignment():
> if self.__Token not in ("Auto", "8", "16", "32", "64", "128", "512", "1K",
> "4K", "32K" ,"64K"):
> raise Warning("Incorrect alignment '%s'" % self.__Token,
> self.FileName, self.CurrentLineNumber)
> - AlignValue = self.__Token
> + #For FFS, Auto is default option same to ""
> + if not self.__Token == "Auto":
> + AlignValue = self.__Token
> if not self.__GetNextToken():
> raise Warning("expected Filename value", self.FileName,
> self.CurrentLineNumber)
>
> FileName = self.__Token.replace('$(SPACE)', ' ')
> if FileName == '}':
> --
> 2.6.1.windows.1
next prev parent reply other threads:[~2016-11-14 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 10:34 [Patch] BaseTools: Fix the bug to support generate FFS by Align=Auto Yonghong Zhu
2016-11-14 8:38 ` Gao, Liming [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-03 13:58 [Patch] BaseTools: Fix the bug to support generate FFS by Align = Auto Yonghong Zhu
2016-11-04 2:10 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4B188F@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox