From: "Gao, Liming" <liming.gao@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
"edk2-devel (edk2-devel@lists.01.org)" <edk2-devel@lists.01.org>,
"Wu, Hao A" <hao.a.wu@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Tian, Feng" <feng.tian@intel.com>, Andrew Fish <afish@apple.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode
Date: Tue, 15 Nov 2016 03:01:47 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B1F83@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAF7UmSyKx-L0C24JaRSdnRAzDFPYoY6n8TFiv1GP6HEeCV5fCw@mail.gmail.com>
Leif:
I think the first step is to update edk2 DSC files to use MdeModulePkg library. Could you enter into one bug for it?
Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, November 15, 2016 1:17 AM
> To: edk2-devel (edk2-devel@lists.01.org) <edk2-devel@lists.01.org>; Gao,
> Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Tian, Feng
> <feng.tian@intel.com>; Andrew Fish <afish@apple.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [edk2] LzmaCustomDecompressLib and
> PeiDxeDebugLibReportStatusCode
>
> Hi all,
>
> Digging through the tree, I spotted we have duplicate instances of the
> above - one set in MdeModulePkg/Library/ and one in
> IntelFrameworkModulePkg.
>
> Looking though the log, I found the commit message explaining the situation:
> ---
> MdeModulePkg: Add two library instances
>
> Copy below two library instances from IntelFrameworkModulePkg to
> MdeModulePkg. Then, Platform dsc can
> refer to them from MdeModulePkg, and remove the dependency of
> IntelFrameworkModulePkg. The ones in
> IntelFrameworkModulePkg are still kept for compatibility.
> 1. PeiDxeDebugLibReportStatusCode
> 2. LzmaCustomDecompressLib
> ---
>
> Even in the main tree, both versions of these are used.
>
> Diffing the clones, 1) has diverged, with 8f77081 going into
> MdeModulePkg and d5cbc27 into IntelFrameworkModulePkg. The
> functionality is identical, but the code is not.
>
> Can we re-evaluate the need to keep the "compatibility" copy around,
> to reduce risk of further diversion?
>
> Regards,
>
> Leif
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-11-15 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 17:16 LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode Leif Lindholm
2016-11-15 3:01 ` Gao, Liming [this message]
2016-11-30 17:20 ` [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-11-30 20:08 ` Laszlo Ersek
2016-12-01 1:12 ` Gao, Liming
2016-12-01 1:52 ` Zeng, Star
2016-12-01 10:23 ` Leif Lindholm
2016-12-01 2:29 ` Kinney, Michael D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4B1F83@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox